From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: Merging the xwidget branch Date: Mon, 18 Jan 2016 22:52:00 +0100 Message-ID: References: <83d1ud8gl0.fsf@gnu.org> <83oadx6jtl.fsf@gnu.org> <83k2ok7s4p.fsf@gnu.org> <8560yzewpg.fsf@iznogoud.viz> <83ziw6dj4v.fsf@gnu.org> <83k2n8dj8q.fsf@gnu.org> <83h9iaew2p.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1453153979 28836 80.91.229.3 (18 Jan 2016 21:52:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Jan 2016 21:52:59 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 18 22:52:47 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aLHjC-0001jy-1I for ged-emacs-devel@m.gmane.org; Mon, 18 Jan 2016 22:52:46 +0100 Original-Received: from localhost ([::1]:33847 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLHjB-0004Z3-DA for ged-emacs-devel@m.gmane.org; Mon, 18 Jan 2016 16:52:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLHj7-0004Yv-5N for emacs-devel@gnu.org; Mon, 18 Jan 2016 16:52:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLHj6-0006nR-1o for emacs-devel@gnu.org; Mon, 18 Jan 2016 16:52:41 -0500 Original-Received: from mx1.bahnhof.se ([213.80.101.11]:35437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLHiz-0006mD-KF; Mon, 18 Jan 2016 16:52:33 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx1-reinject (Postfix) with ESMTP id B735D408DD; Mon, 18 Jan 2016 22:52:30 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF3) Original-Received: from mf3.bahnhof.se ([127.0.0.1]) by localhost (mf3.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E1AY1YcE7XcG; Mon, 18 Jan 2016 22:52:20 +0100 (CET) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf3.bahnhof.se (Postfix) with ESMTP id 6F8573E8D2E; Mon, 18 Jan 2016 22:52:19 +0100 (CET) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id DD9D94E8F35; Mon, 18 Jan 2016 21:52:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EY9MiXZHOSui; Mon, 18 Jan 2016 22:52:00 +0100 (CET) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id 1086B4E8F2E; Mon, 18 Jan 2016 22:52:00 +0100 (CET) In-Reply-To: <83h9iaew2p.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 18 Jan 2016 17:39:10 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.11 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198299 Archived-At: Eli Zaretskii writes: >> From: joakim@verona.se >> Cc: emacs-devel@gnu.org >> Date: Mon, 18 Jan 2016 08:28:58 +0100 >>=20 >> >> Could you help with applying the patch, or otherwise state how we sho= uld proceed? >> > >> > What kind of help do you need with the patch? If it applies cleanly >> > to the emacs-25 branch, just apply it, make sure you write a good >> > commit log message that describes the changes, and push. >> > >> > If anything else is needed, please tell. >>=20 >> I'm not familiar enough with the new commit log conventions. >> I'm supposed to write a commit log entry rather than changelog entries >> right? > > Yes. But the conventions for formatting the commit log are almost the > same as for ChangeLog entries. So this shouldn't be very different > from what you already knew. > >> * NEWS >> ** Xwidgets : A new feature for embedding native widgets >> inside Emacs buffers. If you have gtk3 and webkit-devel installed, >> you can try the embedded webkit browser with m-x xwidget-webkit-browse-u= rl. > > For a significant feature such as this one, the NEWS entry should > mention the main variables/functions/commands provided by the feature. > >>=20 >> * lisp/Changelog >> #+BEGIN_SRC change-log >> 2015-02-01 Gr=E9goire Jadi >>=20 >> * xwidget.el: Improvements to the Xwidget feature. > > No need to say anything about a new file except that it's new. > >> Various improvements to the Xwidget feature. >> * xwidgets.c: > > Likewise here. > >> * emacsgtkfixed.c: >>=20 >> 2015-02-01 Joakim Verona >>=20 >> New files for xwidgets: >> * xwidget.c, xwidget.h: >> Support for the new Xwidget feature. >> * window.c, Makefile.in, buffer.c, dispextern.h, dispnew.c, emacs.c: >> * emacsgtkfixed.c, emacsgtkfixed.h, keyboard.c, lisp.h, print.c: >> * termhooks.h, window.c, xdisp.c, xterm.c >> #+END_SRC >> * Changelog >> #+BEGIN_SRC change-log >> 2015-02-01 Joakim Verona >>=20 >> Support for the new Xwidget feature. >> * configure.ac: > > These, however, need to mention the functions where you made changes, > at least. (You can invoke "C-x 4 a" from a buffer that visits the > diffs, which should avoid manual work to come up with the list of the > functions.) > > Thanks. > How about this?=20 * NEWS ** Xwidgets : A new feature for embedding native widgets inside Emacs buffers. If you have gtk3 and webkit-devel installed, you can access the embedded webkit browser with m-x xwidget-webkit-browse-url. This will open a new buffer with the embedded browser. The buffer will have a new mode, xwidget-webkit mode which is similar to image mode, which supports the webkit widget. *** New functions for xwidget-webkit mode `xwidget-webkit-insert-string',=20 `xwidget-webkit-adjust-size-dispatch', `xwidget-webkit-back', `xwidget-webkit-browse-url', `xwidget-webkit-reload', `xwidget-webkit-current-url', `xwidget-webkit-scroll-backward', `xwidget-webkit-scroll-forward', `xwidget-webkit-scroll-down', `xwidget-webkit-scroll-up', * commit message Support for the new Xwidget feature. * configure.ac:=20 (HAVE_XWIDGETS, WIDGET_OBJ, EMACS_CONFIG_FEATURES):=20 * xterm.c (x_draw_glyph_string, x_draw_bar_cursor):=20 * xdisp.c:=20 (handle_display_spec, handle_single_display_spec, push_it) (pop_it, set_iterator_to_next, dump_glyph) (calc_pixel_width_or_height, fill_xwidget_glyph_string) (BUILD_XWIDGET_GLYPH_STRING, BUILD_GLYPH_STRINGS) (produce_xwidget_glyph, x_produce_glyphs) (get_window_cursor_type):=20 * window.c (Fdelete_window_internal):=20 * termhooks.h (e):=20 * print.c (print_object):=20 * lisp.h (ptrdiff_t):=20 * keyboard.c (kbd_buffer_get_event, make_lispy_event) (syms_of_keyboard):=20 * emacs.c (main):=20 * dispnew.c (update_window, scrolling_window):=20 * dispextern.h (g, i):=20 * Makefile.in (XWIDGETS_OBJ, WEBKIT_CFLAGS, WEBKIT_LIBS) (GIR_LIBS, ALL_CFLAGS, base_obj, LIBES):=20 * keyboard.c (kbd_buffer_get_event):=20 * emacsgtkfixed.c (emacs_fixed_gtk_widget_size_allocate) (emacs_fixed_class_init):=20 New files for xwidgets: * xwidget.c, xwidget.h, xwidget.el: Co-authored-by: Gr=E9goire Jadi Various improvements to the Xwidget feature. * xwidgets.c: * emacsgtkfixed.c: * xwidget.el: --=20 Joakim Verona