From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: syntax based indentation for SQL files (ELPA package proposal) Date: Tue, 02 Oct 2018 09:49:50 -0400 Message-ID: References: <808t48ny4y.fsf@gmail.com> <86a7nxb8p8.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1538488071 27985 195.159.176.226 (2 Oct 2018 13:47:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2018 13:47:51 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 02 15:47:47 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7L1a-00074W-F0 for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2018 15:47:42 +0200 Original-Received: from localhost ([::1]:43832 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7L3h-0007RK-3O for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2018 09:49:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7L3Y-0007Q7-8d for emacs-devel@gnu.org; Tue, 02 Oct 2018 09:49:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7L3U-0002Xe-0r for emacs-devel@gnu.org; Tue, 02 Oct 2018 09:49:44 -0400 Original-Received: from mail-it1-x134.google.com ([2607:f8b0:4864:20::134]:37966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7L3Q-0002Wn-Dq for emacs-devel@gnu.org; Tue, 02 Oct 2018 09:49:37 -0400 Original-Received: by mail-it1-x134.google.com with SMTP id i76-v6so3677246ita.3 for ; Tue, 02 Oct 2018 06:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=x5segNf3NRRKQjbdSLElxOm4B6ta5kEyc1iwCU7Fb3A=; b=ff+CF3DuQ0oubNv9I/e81U1aAo6txlZUwjL0v7bJuV3FzA2WmTxwEkAnGJemwH2nwm EsUl7NQuiBRNTEb+83C3zKODGo10l0SupEtnpRNdGLoNhwOA/ErxPwEpWOdN3vx9PUTb MmV99PKYwzuXPrqCnBXjsKktaSoHPqR+hvQ0XpSkD0a70RWKDL4LGfq5yZ+AJFuUAE/6 ruW1FioJ3mpSbPnsllpCMTc4MKn2qP0EhGYuH3qzg+p93v77Fl0dMPj3DQEOVno/goBd 69cTxYh2RfQp1cN3p0CE7H9W3TNuNgWw2DogUGcVEK+qBd5ZGMBtkM8hotp4SKMPmQhs heAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=x5segNf3NRRKQjbdSLElxOm4B6ta5kEyc1iwCU7Fb3A=; b=tXrpQUYKei8VqMBvUkIJsPQdyHPjNvWQdDPI/MWgGgycy8gLcsWbcTYuplS8NWDMwc NJKGpr6fB5EAGoBx8vwQDyx2UQ3tZGOyg19Ku5ZMNp5hmyWPmPPjMehhjmNb5QEjELYK 2JkIQ20nwNwAiQJSkxZtFKQdPgYNDo/FTs6kHQomWd5fdx8Ygbcl2tGgL0jbqSyQg9zS 3jgHSCjz2jpI5bPDaPCd3oxdxDdkblYWd96Es4XJmWEjyVbj5CpYhydw020OSF0CJM6M r76TTMG9CLWBEHkB68xTRJjtpNINnjcOYTXv+CnKtLdyeXZ3413Uso83Op5i3zmLtvLG MvGg== X-Gm-Message-State: ABuFfogIXNZWYQx+F0UxhUGfNyeo6JfgUqP8TKgZS0sY8MI7ckMeQDNb Zk9FBiQPv7ovLkd2+Mggvc8gwOi/pG4= X-Google-Smtp-Source: ACcGV614dHWpbBWIgJ6lOylTnxHik+nh0kqNEl4PO4tUHc/L2k9uZwmtERN2eR5b97tuMDudT94YUQ== X-Received: by 2002:a24:8d85:: with SMTP id w127-v6mr1833845itd.94.1538488174746; Tue, 02 Oct 2018 06:49:34 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id i77-v6sm6511705itb.16.2018.10.02.06.49.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 06:49:33 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 02 Oct 2018 08:57:02 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::134 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230191 Archived-At: Stefan Monnier writes: >> This patch looks like it has been applied in the wrong place. Emacs >> builtin code should not depend on an external package. Why did you add >> this change into emacs, rather than the package that defines >> sqind-minor-mode ? > > It doesn't actually depend on sql-indent. It just makes use of it > when available. Given that sql-indent is in GNU ELPA, I think this is > perfectly acceptable (and I'm pretty sure we have other similar cases > already in emacs.git, some of which for packages that aren't even in > GNU ELPA). Yes, EUDC's optional dependency on BBDB (which is in GNU ELPA now) is another example. I don't love it, but I've learned to live with it, especially given that the BBDB maintainer prefers the current arrangement. At one point there was talk of resolving these dependencies during the creation of Emacs release tarballs. Thomas