From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: xterm.c:handle_one_xevent question
Date: 25 Feb 2004 11:33:17 +0100 [thread overview]
Message-ID: <m3hdxfwis2.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <buo1xoj8wpt.fsf@mcspd15.ucom.lsi.nec.co.jp>
Miles Bader <miles@lsi.nec.co.jp> writes:
> I got an emacs abort at the following place in handle_one_xevent
> (xterm.c):
>
It seems that my recent change to read_avail_input (which
significantly reduced the size of the event buffer) has triggered
some errors in the "read_socket_hook" functions on W32 and X (and
probably MAC as well).
The problem is that the numchars parameter indicating the buffer size
is not checked to see how much can be stuffed into the buffer (and
return when full), but rather [in an inconsistent way] to check that
there is always sufficient space in the buffer or abort otherwise.
I already posted a quick patch for W32 to this list, but haven't
committed it yet, as the rest of the code should be cleaned up.
If someone will commit it, you're welcome.
I will go through the X and MAC code to see what's needed to fix this,
but it will have to wait a few days, so if somebody else want to take
up the challange, feel free to do so.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2004-02-25 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-25 7:06 xterm.c:handle_one_xevent question Miles Bader
2004-02-25 8:47 ` Jan D.
2004-02-25 10:33 ` Kim F. Storm [this message]
2004-02-25 10:04 ` Jan D.
2004-02-25 11:26 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hdxfwis2.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).