From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: abort in wait_reading_process_input Date: 24 May 2004 09:50:01 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <87y8nikbgw.fsf@emacswiki.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1085385232 10470 80.91.224.253 (24 May 2004 07:53:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 24 May 2004 07:53:52 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon May 24 09:53:41 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BSAHF-00051w-00 for ; Mon, 24 May 2004 09:53:41 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BSAHE-00011O-00 for ; Mon, 24 May 2004 09:53:40 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BSAEN-0001IZ-SL for emacs-devel@quimby.gnus.org; Mon, 24 May 2004 03:50:44 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BSAEH-0001Hc-A3 for emacs-devel@gnu.org; Mon, 24 May 2004 03:50:37 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BSADf-00015Y-5P for emacs-devel@gnu.org; Mon, 24 May 2004 03:50:30 -0400 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.34) id 1BSADe-00014X-Fi for emacs-devel@gnu.org; Mon, 24 May 2004 03:49:58 -0400 Original-Received: (qmail 22897 invoked from network); 24 May 2004 07:49:55 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 24 May 2004 07:49:55 -0000 Original-To: Alex Schroeder In-Reply-To: <87y8nikbgw.fsf@emacswiki.org> Original-Lines: 41 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23877 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23877 Alex Schroeder writes: > When running ERC, the Emacs IRC Client that is not (yet) part of > Emacs, I'm getting an abort in wait_reading_process_input. > > Backing out the following change did not help: > > revision 1.428 > date: 2004/05/13 23:07:07; author: kfstorm; state: Exp; lines: +4 -3 > (wait_reading_process_input): Make reentrant. > Make Available and Connecting non-static. Save and restore value > of waiting_for_user_input_p. > > Alex. > Does the following patch help: *** process.c 14 May 2004 00:42:09 +0200 1.428 --- process.c 24 May 2004 09:48:17 +0200 *************** *** 4581,4587 **** } } #ifdef NON_BLOCKING_CONNECT ! if (check_connect && FD_ISSET (channel, &Connecting)) { struct Lisp_Process *p; --- 4581,4588 ---- } } #ifdef NON_BLOCKING_CONNECT ! if (check_connect && FD_ISSET (channel, &Connecting) ! && FD_ISSET (channel, &connect_wait_mask)) { struct Lisp_Process *p; -- Kim F. Storm http://www.cua.dk