From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: [Chong Yidong] Re: Tool-bar buttons unresponsive with tooltips on Date: Mon, 17 Oct 2005 00:59:03 +0200 Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1129503604 23397 80.91.229.2 (16 Oct 2005 23:00:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 16 Oct 2005 23:00:04 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 17 01:00:02 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ERHTz-0007Aj-4k for ged-emacs-devel@m.gmane.org; Mon, 17 Oct 2005 00:59:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ERHTy-0004LY-J8 for ged-emacs-devel@m.gmane.org; Sun, 16 Oct 2005 18:59:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ERHTj-0004K7-Os for emacs-devel@gnu.org; Sun, 16 Oct 2005 18:59:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ERHTh-0004IN-V5 for emacs-devel@gnu.org; Sun, 16 Oct 2005 18:59:43 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ERHTh-0004IF-RR for emacs-devel@gnu.org; Sun, 16 Oct 2005 18:59:41 -0400 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ERHTi-0006Dk-3v for emacs-devel@gnu.org; Sun, 16 Oct 2005 18:59:42 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepa.post.tele.dk (Postfix) with SMTP id B4DDA47FE25 for ; Mon, 17 Oct 2005 00:59:40 +0200 (CEST) Original-To: emacs-devel@gnu.org User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44151 Archived-At: Jason, Can you explain why you added that specific line. I can see that it looks like a reasonable thing to do, but Chong has problems with it (I don't). What problem was it supposed to fix? > From: Chong Yidong > > The bug goes away if I remove the indicated line in > note_mouse_movement, in xterm.c. > > /* Has the mouse moved off the glyph it was on at the last sighting? */ > if (event->x < last_mouse_glyph.x > || event->x >= last_mouse_glyph.x + last_mouse_glyph.width > || event->y < last_mouse_glyph.y > || event->y >= last_mouse_glyph.y + last_mouse_glyph.height) > { > frame->mouse_moved = 1; > last_mouse_scroll_bar = Qnil; > note_mouse_highlight (frame, event->x, event->y); > /* Remember which glyph we're now on. */ > remember_mouse_glyph (frame, event->x, event->y, &last_mouse_glyph); > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > return 1; > } > > return 0; > } > > The call to remember_mouse_glyph was not there in earlier versions of > xterm.c. -- Kim F. Storm http://www.cua.dk