From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: A cleaning-up patch for parse-time.el Date: Fri, 25 Mar 2016 16:24:56 +0100 Message-ID: References: <87a8lveya2.fsf@mbork.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458919535 23982 80.91.229.3 (25 Mar 2016 15:25:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Mar 2016 15:25:35 +0000 (UTC) Cc: Emacs Developers To: Marcin Borkowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 25 16:25:25 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ajTc4-0002gF-4q for ged-emacs-devel@m.gmane.org; Fri, 25 Mar 2016 16:25:24 +0100 Original-Received: from localhost ([::1]:56650 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajTc2-0004x7-Tq for ged-emacs-devel@m.gmane.org; Fri, 25 Mar 2016 11:25:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajTbo-0004uF-Lr for emacs-devel@gnu.org; Fri, 25 Mar 2016 11:25:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajTbl-000895-Gl for emacs-devel@gnu.org; Fri, 25 Mar 2016 11:25:08 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:38285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajTbl-00087B-B7 for emacs-devel@gnu.org; Fri, 25 Mar 2016 11:25:05 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.84_2) (envelope-from ) id 1ajTbc-0004Bf-OO; Fri, 25 Mar 2016 16:25:02 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXk2eINBggFAgNiMzql jJYxEBaAXWsWCQzDU4wAAAACS0lEQVQ4jY2TQW/jIBCFkZLmHqepz6ayem2Lja+RTDivQ4mvlcDT s2tl+fv7wHG7VbfSjhIHz6f3ZgIDy/h2m/FrbPG5Bsuyz3xiC8C3+MgWs4rPCv49im1g/0hDkQMU FyNJP/GdZwilFIkxwIqfSSnd7c9sibWrXZMBOOmM8ZUiT/qAPHlNQ1Q4IwStPTkiemRaAqojQAiT V2qt5mhinrEI+MUfFnst5Ly4AdjLBayHF6Xn9Q2KT5JUetlYif7odVEAJEk7KbYGoAXg70Gybkxs VWlhHq/FE2hD6gZtie7M1DBmM2hGnqw3wrtTSQ22C4DcOA0zWFnZnvjZ+lMEDTe+nUFryZ347xcW QVYYr468SsA4/8xL2vQo/iBjbV6+JoXwb5yTOaZtJ1Vba+NmtL3QqPziVwl4bWshavTbdrLm7/yW zYC0iAGvVW9O/IHfs0WxgI3NC0xKyVbjV7DuswdLESyK2oo6gjo2/14ePoDtr21leZATJUUVuxr5 ZGJbm67IJY4xAd3sLef3U/cYvfIgIkDx6rmAgJd33S/settfhKgSuIwhjm852QonmxqcQXGxNUDY NZWPJ+swZYcIrDURjPtBSK0wdEJKdcRQy7c04N3OCekkKgsMM8D2TE6eoNgNtXGEChgidRxZhk2E vO4vACIqMLBqgBVGGuOAmkTSEZZekR7G+aBi0N8xpMv5NXJcp3ijtrcktfNUKwWbSsan8x3AnccR kj+iA/ySlninp2iVJ4cu2Xwafq8xR/gB5P8P5ioh/KDIQ/gDFcbeFa3xClsAAAAASUVORK5CYII= In-Reply-To: <87a8lveya2.fsf@mbork.pl> (Marcin Borkowski's message of "Sat, 19 Mar 2016 08:12:53 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202224 Archived-At: Marcin Borkowski writes: While the patch is obviously correct, parts of it isn't all that useful: > * lisp/calendar/parse-time.el (parse-time-string-chars) > (parse-time-tokenize): Make code more readable [...] > -(defsubst parse-time-string-chars (char) > - (cond ((<= ?a char ?z) ?a) > - ((<= ?0 char ?9) ?0) > - ((eq char ?+) 1) > - ((eq char ?-) -1) > - ((eq char ?:) ?d))) > +(defsubst parse-time-string-chars (character) > + "Classify CHARACTER for `parse-time-tokenize'." > + (cond ((<= ?a character ?z) ?a) > + ((<= ?0 character ?9) ?0) > + ((eq character ?+) 1) > + ((eq character ?-) -1) > + ((eq character ?:) ?d))) Using `char' instead of `character' is fine, I think. (See `goto-char' and a gazillion other usages in the Emacs source code.) [...] > - (not (setq c (parse-time-string-chars (aref string index))))) > + (null (setq c (parse-time-string-chars (aref string index))))) not vs null isn't very interesting, in my opinion. > - (setq start index all-digits (eq c ?0)) > + (setq start index > + all-digits (eq c ?0)) This one makes sense, though (as does the comment fix). I've applied those bits to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no