From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 0/6] xwidget webkit: Use WebKit2 API. Date: Wed, 21 Sep 2016 14:05:56 +0200 Message-ID: References: <20160921115018.29576-1-rekado@elephly.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1474459626 29956 195.159.176.226 (21 Sep 2016 12:07:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Sep 2016 12:07:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Ricardo Wurmus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 21 14:07:00 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmgIc-0005zd-Sw for ged-emacs-devel@m.gmane.org; Wed, 21 Sep 2016 14:06:51 +0200 Original-Received: from localhost ([::1]:42058 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmgIb-0000l6-7q for ged-emacs-devel@m.gmane.org; Wed, 21 Sep 2016 08:06:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmgIQ-0000kr-9r for emacs-devel@gnu.org; Wed, 21 Sep 2016 08:06:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmgIL-0000Re-4j for emacs-devel@gnu.org; Wed, 21 Sep 2016 08:06:38 -0400 Original-Received: from mx2.bahnhof.se ([213.80.101.12]:12405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmgIK-0000R0-U2 for emacs-devel@gnu.org; Wed, 21 Sep 2016 08:06:33 -0400 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx2-reinject (Postfix) with ESMTP id D76A240F38; Wed, 21 Sep 2016 14:06:30 +0200 (CEST) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF4) Original-Received: from mf4.bahnhof.se ([127.0.0.1]) by localhost (mf4.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OZbv2fykS8XE; Wed, 21 Sep 2016 14:06:14 +0200 (CEST) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf4.bahnhof.se (Postfix) with ESMTP id A19DF3D7938; Wed, 21 Sep 2016 14:06:14 +0200 (CEST) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id 352084FAECF; Wed, 21 Sep 2016 12:06:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1RZ8TaL6J4Ad; Wed, 21 Sep 2016 14:05:56 +0200 (CEST) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id 9B9074FAECA; Wed, 21 Sep 2016 14:05:56 +0200 (CEST) In-Reply-To: <20160921115018.29576-1-rekado@elephly.net> (Ricardo Wurmus's message of "Wed, 21 Sep 2016 13:50:12 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207655 Archived-At: Ricardo Wurmus writes: > O fellow humans on emacs-devel! > > I noticed that for the embedding of a WebKit widget in Emacs an old > version of WebKitGtk is needed, because the code in "src/xwidget.c" > targets the WebKit1 API. As far as I know, only the latest version of > WebKitGtk is actively maintained, so it seems like a good idea to make > Emacs work with the latest version. I haven't had a chance to try this yet, but I'm very happy that you are working on this! > > The first patch in this series adjusts the code such that the WebKit2 > API is used instead, which allows users to build Emacs with the latest > version of WebKit(2)Gtk. Due to process separation in WebKit2Gtk, > scrolling is now supposed to be done in the UI process. This is what > the second patch does; it implements scrolling by executing JavaScript > in the WebKit view. (Maybe the first two commits should be squashed?) > > The other patches are simple changes to make interacting with the > WebKit widget a little easier. > > If these patches are okay I'd like to continue by removing the title > hack, which is currently used to get a stringified return value from > JavaScript. This is no longer needed when using the WebKit2 API as it > supports passing a callback to process any JS return values. Indeed the title hack is horrible, and I'm glad you have found a better solution. > ~~ Ricardo > > PS: I did copyright assigment for GNU Guile already, but I'm not sure > if copyright assignment is on file for Emacs already. > > Ricardo Wurmus (6): > xwidget: Use WebKit2 API > Remove scrolled window container around WebKit widget > Implement zoom for WebKit widget. > xwidget: Bind "beginning-of-buffer" and "end-of-buffer" > Let initial WebKit view fill window > xwidget: Map "previous-line" and "next-line" to scroll > > configure.ac | 4 +- > lisp/xwidget.el | 56 +++++++++--- > src/xwidget.c | 270 ++++++++++++++++++++++---------------------------------- > src/xwidget.h | 3 - > 4 files changed, 151 insertions(+), 182 deletions(-) -- Joakim Verona