From: joakim@verona.se
To: Ricardo Wurmus <rekado@elephly.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 0/6] xwidget webkit: Use WebKit2 API.
Date: Wed, 21 Sep 2016 14:05:56 +0200 [thread overview]
Message-ID: <m3h9994fvf.fsf@chopper> (raw)
In-Reply-To: <20160921115018.29576-1-rekado@elephly.net> (Ricardo Wurmus's message of "Wed, 21 Sep 2016 13:50:12 +0200")
Ricardo Wurmus <rekado@elephly.net> writes:
> O fellow humans on emacs-devel!
>
> I noticed that for the embedding of a WebKit widget in Emacs an old
> version of WebKitGtk is needed, because the code in "src/xwidget.c"
> targets the WebKit1 API. As far as I know, only the latest version of
> WebKitGtk is actively maintained, so it seems like a good idea to make
> Emacs work with the latest version.
I haven't had a chance to try this yet, but I'm very happy that you are
working on this!
>
> The first patch in this series adjusts the code such that the WebKit2
> API is used instead, which allows users to build Emacs with the latest
> version of WebKit(2)Gtk. Due to process separation in WebKit2Gtk,
> scrolling is now supposed to be done in the UI process. This is what
> the second patch does; it implements scrolling by executing JavaScript
> in the WebKit view. (Maybe the first two commits should be squashed?)
>
> The other patches are simple changes to make interacting with the
> WebKit widget a little easier.
>
> If these patches are okay I'd like to continue by removing the title
> hack, which is currently used to get a stringified return value from
> JavaScript. This is no longer needed when using the WebKit2 API as it
> supports passing a callback to process any JS return values.
Indeed the title hack is horrible, and I'm glad you have found a better solution.
> ~~ Ricardo
>
> PS: I did copyright assigment for GNU Guile already, but I'm not sure
> if copyright assignment is on file for Emacs already.
>
> Ricardo Wurmus (6):
> xwidget: Use WebKit2 API
> Remove scrolled window container around WebKit widget
> Implement zoom for WebKit widget.
> xwidget: Bind "beginning-of-buffer" and "end-of-buffer"
> Let initial WebKit view fill window
> xwidget: Map "previous-line" and "next-line" to scroll
>
> configure.ac | 4 +-
> lisp/xwidget.el | 56 +++++++++---
> src/xwidget.c | 270 ++++++++++++++++++++++----------------------------------
> src/xwidget.h | 3 -
> 4 files changed, 151 insertions(+), 182 deletions(-)
--
Joakim Verona
next prev parent reply other threads:[~2016-09-21 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 11:50 [PATCH 0/6] xwidget webkit: Use WebKit2 API Ricardo Wurmus
2016-09-21 11:50 ` [PATCH 1/6] xwidget: " Ricardo Wurmus
2016-09-21 11:50 ` [PATCH 2/6] Remove scrolled window container around WebKit widget Ricardo Wurmus
2016-09-21 11:50 ` [PATCH 3/6] Implement zoom for " Ricardo Wurmus
2016-09-21 11:50 ` [PATCH 4/6] xwidget: Bind "beginning-of-buffer" and "end-of-buffer" Ricardo Wurmus
2016-09-21 11:50 ` [PATCH 5/6] Let initial WebKit view fill window Ricardo Wurmus
2016-09-21 11:50 ` [PATCH 6/6] xwidget: Map "previous-line" and "next-line" to scroll Ricardo Wurmus
2016-09-21 12:05 ` joakim [this message]
2016-09-21 14:51 ` [PATCH 0/6] xwidget webkit: Use WebKit2 API Eli Zaretskii
2016-09-21 18:47 ` Ricardo Wurmus
2016-09-21 19:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3h9994fvf.fsf@chopper \
--to=joakim@verona.se \
--cc=emacs-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).