unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: gjadi@omecha.info (Grégoire Jadi)
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] Search for image from the beginning of the fetched buffer
Date: Mon, 24 Jul 2017 17:30:06 +0200	[thread overview]
Message-ID: <m3h8y17szl.fsf@stories> (raw)
In-Reply-To: <87r2x8u6jr.fsf@omecha.info> ("Grégoire Jadi"'s message of "Sat, 22 Jul 2017 12:09:28 +0200")

gjadi@omecha.info (Grégoire Jadi) writes:

> After a bit of lurking, I found out that the image where correctly
> restored from the cache, because it starts to parse at position 1.
> However, the position in the buffer in `shr-image-fetched' is something
> else >1. I haven't figured out why the position isn't right (I suspect
> something in `url-file').
>
> The fix I've found so far is to force position 1 in `shr-image-fetched'.
> I've also disabled multibyte because `shr-get-image-data' does it, but
> it might be unnecessary.
> Patch below.

Thanks; applied (but I left the multibyte stuff out -- it shouldn't be
necessary).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2017-07-24 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-22 10:09 [PATCH] Search for image from the beginning of the fetched buffer Grégoire Jadi
2017-07-24 15:30 ` Lars Ingebrigtsen [this message]
2017-07-24 16:42   ` Grégoire Jadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3h8y17szl.fsf@stories \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=gjadi@omecha.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).