From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [hober0@gmail.com: Re: mode-line redisplay bug] Date: Tue, 11 Oct 2005 17:14:19 +0200 Message-ID: References: <46247494-627E-4DE6-892E-57AAF7C70E1C@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1129043927 10909 80.91.229.2 (11 Oct 2005 15:18:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 Oct 2005 15:18:47 +0000 (UTC) Cc: "Jan D." , emacs-devel@gnu.org, rms@gnu.org, Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 11 17:18:43 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EPLrk-0008Un-Qy for ged-emacs-devel@m.gmane.org; Tue, 11 Oct 2005 17:16:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EPLrk-0004uI-0K for ged-emacs-devel@m.gmane.org; Tue, 11 Oct 2005 11:16:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EPLrY-0004sR-2A for emacs-devel@gnu.org; Tue, 11 Oct 2005 11:16:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EPLrX-0004rh-20 for emacs-devel@gnu.org; Tue, 11 Oct 2005 11:16:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EPLrW-0004rU-TC for emacs-devel@gnu.org; Tue, 11 Oct 2005 11:16:18 -0400 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EPLqU-0004MV-PX; Tue, 11 Oct 2005 11:15:14 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepb.post.tele.dk (Postfix) with SMTP id 14B335EE0B6; Tue, 11 Oct 2005 17:15:06 +0200 (CEST) Original-To: YAMAMOTO Mitsuharu In-Reply-To: (YAMAMOTO Mitsuharu's message of "Tue, 11 Oct 2005 21:38:18 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:43879 Archived-At: YAMAMOTO Mitsuharu writes: >>>>>> On Tue, 11 Oct 2005 12:21:50 +0200, storm@cua.dk (Kim F. Storm) said: > >> Below is a patch which does this, but I have only tested it on X. >> Could somebody test it on W32 and MAC? > > I think it still has some off-by-one errors. Thanks for finding the bugs in my code. Does it still have errors with your changes? In any case, I have committed changes to fix buffer positions in mouse click events and mouse movement events in the margins, fringes and scroll bars. Now, marking text with the mouse seems to work alright when you drag outside left/right borders of the text area. > > (The ON_SCROLL_BAR case still does not work well.) Does it work better now? > > And again, if it is corrected, the problems 2.1 and 2.2 I said in > http://lists.gnu.org/archive/html/emacs-pretest-bug/2005-06/msg00148.html > will appear. > >> But the MAC version doesn't actually call "remember_mouse_glyph" >> anywhere (it uses pixel_to_glyph_coords as the other versions used >> to do) so I don't expect this to have any effect on the Mac...? > > The patch below adds "remember_mouse_glyph" calls. Actually, a part > of this patch is included in the patch in the above URL. I think we should commit these patches -- and then address the 2.1 and 2.2 problems subsequently -- it is too hard to fix everything at once (and keep patches synchronized). I'll commit the current set of changes (but just the Mac-related change to macterm.c that you included in your mail) tomorrow unless anyone objects before then... -- Kim F. Storm http://www.cua.dk