From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Remove mouse-face in Occur buffers Date: Mon, 31 Oct 2005 12:14:39 +0100 Message-ID: References: <87br19nzk1.fsf@jurta.org> <87zmosceb3.fsf@jurta.org> <87hdayjjq8.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1130760755 13164 80.91.229.2 (31 Oct 2005 12:12:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 31 Oct 2005 12:12:35 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 31 13:12:32 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EWYWb-0007QQ-BD for ged-emacs-devel@m.gmane.org; Mon, 31 Oct 2005 13:12:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EWYWa-0004Bf-0P for ged-emacs-devel@m.gmane.org; Mon, 31 Oct 2005 07:12:28 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EWXxS-0007le-0D for emacs-devel@gnu.org; Mon, 31 Oct 2005 06:36:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EWXsb-0006Ji-5p for emacs-devel@gnu.org; Mon, 31 Oct 2005 06:31:09 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EWXdu-0004Tr-Ud for emacs-devel@gnu.org; Mon, 31 Oct 2005 06:16:01 -0500 Original-Received: from [195.41.46.237] (helo=pfepc.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EWXdu-0006lW-Os for emacs-devel@gnu.org; Mon, 31 Oct 2005 06:15:58 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepc.post.tele.dk (Postfix) with SMTP id B2282262849; Mon, 31 Oct 2005 12:15:57 +0100 (CET) Original-To: Juri Linkov In-Reply-To: <87hdayjjq8.fsf@jurta.org> (Juri Linkov's message of "Mon, 31 Oct 2005 09:44:55 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:45165 Archived-At: Juri Linkov writes: > The default value of `yank-excluded-properties' also includes > `invisible' which will unhide copied invisible text in the Occur buffer. > This is better than displaying lines with hidden matches. But maybe > occur should skip invisible text in the original buffer, and not to copy > lines where matches have invisible properties on them (i.e. like > isearch skips invisible text)? I have no opinion about that. > Anyway, in the patch below the default value of `occur-excluded-properties' > is the same as of `yank-excluded-properties'. Looks good to me. > And it also servers as > the default value of the `keep-props' argument (which before this patch > was unconditionally non-nil). Ok, but then these checks in occur-accumulate-lines and occur-engine seems superfluous: > (if (fboundp 'jit-lock-fontify-now) > (jit-lock-fontify-now beg end))) > (push > ! (if (and keep-props (not (eq occur-excluded-properties t))) Just test keep-props here (it is nil if occur-excluded-properties = t. > (text-property-not-all begpt endpt 'fontified t)) > (if (fboundp 'jit-lock-fontify-now) > (jit-lock-fontify-now begpt endpt))) > ! (if (and keep-props (not (eq occur-excluded-properties t))) Likewise... -- Kim F. Storm http://www.cua.dk