More Emacs compilation warnings?

More Emacs compilation warnings?

[Lars Magne Ingebrigtsen]

A thing just occurred to me about the int = PV thing -- why isn't this a
compilation warning?  Would there be too many false positives?  Or
doesn't a warning like that exist?

Let's see...

http://gcc.gnu.org/ml/gcc-help/2008-08/msg00024.html

-Wconversion -- it's apparently a somewhat newish option?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: More Emacs compilation warnings?

[Lars Magne Ingebrigtsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Would there be too many false positives? 

I don't know about false positives, but adding -Wconversion certainly
adds enough warnings of the type:

dispnew.c:6060: warning: conversion to 'int' from 'Lisp_Object' may alter its value
dispnew.c:6106: warning: conversion to 'int' from 'long int' may alter its value
dispnew.c:6421: warning: conversion to 'int' from 'long int' may alter its value
dispnew.c:6422: warning: conversion to 'int' from 'long int' may alter its value
dispnew.c:6424: warning: conversion to 'long unsigned int' from 'int' may change the sign of the result
dispnew.c:6424: warning: conversion to 'unsigned int' from 'long unsigned int' may alter its value
...

[larsi@quimbies ~/src/emacs/trunk/src]$ make 2>&1 | grep warning | wc -l
7152

Somebody has a lot of work to do.  :-)

(Or not.)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen