From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Errors in redisplay in eww Date: Sat, 09 Jan 2016 10:13:16 +0100 Message-ID: References: <83twn1dzg8.fsf@gnu.org> <874mf16xiy.fsf@gnus.org> <8360zhdtv9.fsf@gnu.org> <83io3fdipq.fsf@gnu.org> <838u48cr19.fsf@gnu.org> <83vb795fgr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1452330849 20655 80.91.229.3 (9 Jan 2016 09:14:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Jan 2016 09:14:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 09 10:14:00 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aHpav-0000nX-DF for ged-emacs-devel@m.gmane.org; Sat, 09 Jan 2016 10:13:57 +0100 Original-Received: from localhost ([::1]:39792 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHpau-00080d-LN for ged-emacs-devel@m.gmane.org; Sat, 09 Jan 2016 04:13:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHpah-0007yc-8N for emacs-devel@gnu.org; Sat, 09 Jan 2016 04:13:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHpad-000812-5R for emacs-devel@gnu.org; Sat, 09 Jan 2016 04:13:43 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:37981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHpac-00080t-Uy; Sat, 09 Jan 2016 04:13:39 -0500 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aHpaG-00089z-G2; Sat, 09 Jan 2016 10:13:16 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAADFBMVEU1Njacm5jOzcv6+vmX d6tUAAACSElEQVQokSXOT0ySYQDH8d+LoHN2QBdr1cwutZWHTh06AWW5buh4pBdmeEgKCLlkKs3p +nPqQiUaOkM34R0vi+eEJQuetg5dbU37t3JtgqlLT49M3+Dpbd1+n/0uXyzbTGmSD4SGXnoofo4f Jcm87869dbMVatTie16I7WvrfVaE5ob7lwps54JznuJ7qtq/MxpcJ6qfwj8jVlaLmWgqthTG14n6 J5Ns+n7SxylcUUsLGVNLDnkhDJKDgRW3+QHTERtFtyiK7YMRzhCSYdGxJlIlhnD80WW1SKn4EaNw 06fxBSlQo5+JQHJtfBVS/ZJ3goTh35BvAUheJy6GXh7o03Em6x9IIL4nP9TRyCKjQaRpQd8wiaGM hmw4AjNxGFgkrKN9BCdPfDCw6TENXs9r4FhUYmtMg7vnmg6npCbUDCriDzAwByGqFO/ZbR3zEt+L ekBMs7CkndLGC7Sj2ekGLLa6rTw64SDHYZRsdYubxgY4zJ5xI8xNyq9DdRhsnlrW0ab8Dj3AsJ3o 1bYg/bT/DmabqRUwPM7GS5f0XnvTMlrdSlx+pj+wi8xE52b57keYjTib4F3y9l6/ghuAlOdX0lta OQOHo6Ejy68qeZp0gRxumz3NPVM0Er+J3pDypjHnmX6V3/HAm6hUO3IRNb+1q8EqhOjiwZnAJNUw JkStmyfK6Syt/IOw5xbLgQ3Xf1zk1VSSKxWcE6Jo4AUfF0MKvEIw8NoXTawcQYsO2/laPLjLO9Ej xO7bU2zW+63UA0L8cmyQyG5VVf8CtHEodbLbHikAAAAASUVORK5CYII= In-Reply-To: <83vb795fgr.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 04 Jan 2016 21:09:40 +0200") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aHpaG-00089z-G2 MailScanner-NULL-Check: 1452935596.81703@S0jalGH37rK54Q4re6/4zA X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197892 Archived-At: Eli Zaretskii writes: > No, add-face-text-property and shr-colorize-region are not the > culprit, at least they don't seem to be. The problem is here: > > (dolist (line lines) > (end-of-line) > (let ((start (point))) > (insert > line > (propertize " " > 'display `(space :align-to (,pixel-align)) > 'face (and (> (length line) 0) > (shr-face-background > (get-text-property > (1- (length line)) 'face line))) > 'shr-table-indent shr-table-id) > shr-table-vertical-line) > (shr-colorize-region > start (1- (point)) (nth 5 column) (nth 6 column))) > (forward-line 1)) > > shr-face-background returns nil when get-text-property returns just > variable-pitch, so we get 'face nil' in the properties, and the rest > is history. I see. > Can you tell how come get-text-property returns something else in your > case? No, it has to return the same as you're seeing. Is it possible that my Emacs just isn't warning about these nil faces? The right fix here is probably not to propertize the `face' is `shr-face-background' returns nil, I guess. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no