From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-dup.el Date: Mon, 25 Mar 2019 18:42:32 +0100 Message-ID: References: <8736nbip4l.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="107118"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eric Abrahamsen , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 19:16:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8U9Q-000Re2-On for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 19:16:48 +0100 Original-Received: from localhost ([127.0.0.1]:46490 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8U9P-0007KA-E1 for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2019 14:16:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8TqQ-0007RH-JZ for emacs-devel@gnu.org; Mon, 25 Mar 2019 13:57:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8TcP-0002NF-DS for emacs-devel@gnu.org; Mon, 25 Mar 2019 13:42:43 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:49600) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8TcN-0002Lv-1j for emacs-devel@gnu.org; Mon, 25 Mar 2019 13:42:40 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h8TcG-0004h4-VA; Mon, 25 Mar 2019 18:42:35 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEVhTl/Gy9Oho6vBxM3P 1d3XTdH2AAACSklEQVQ4jWVUgZWrMAxzAwPUTQYIDgMQ3AEayP4znRTov/ff5a4ULCw7slKRNapW 7amn1HFtXWPHVV5TjO7aNV0Ago0fCUdUB1JdE/5GVJmRZ/ddxLIEMwvCSzZVWSQqgP9WNmTIpzXP VyB8kQBgm1uL2xX8BTzJDCrfvhz/ABU5iv4pEqrKZzqaqpmbZRsLeaV3mfOcVDviLyuMHyXaG4C8 5wpJFvczxlrH3nvXLofgy1Y+3ZLcwPScWjTbbYeSPUEOLkqylqbkhoz9u3AnLi93AlA/dUWGDh0l fKYr432zkAeL6gLYi2NcaQTHC03eohGAAQBXulpiRviEVq8tYwr6S7XN2zJqWGUSB3sBq6TaGXcv tMRpdgFyhKsrNKAt9d3kAp6DisKysfSE6HEAs6xLvQFXhxvEqQGopOrNhBoAQmTTGNSzch/8B2AE bqqFAyxVnbKD9M6QKBBxZHDvo0aFIeUTDtYoVhtqJngy+JvzmPMEFq94TfWEs0Jo9Lxg6yP2Ymd5 uM7yCmCXA2aHf4dFwERfEQjbVCoBmD7slodNH2NQUmrddYdINs4AgAlAEV/qFmCUYGGUYQNjUAKR thDwfFfBvZIqF687D9O006RsbGkc1BvFnYHid8thiTwGwnaR4MNfjuMFIHHmE0Os9AV4D6oVXxFP dgPse5woOZ1PNvKsRvjMI+wzbcEpIn8GdvwQxHTyJMmDKp4DuhYA+kug4ktOpREIxarMIFXYQg4H 3IZYzI+jwtV6qjzyJBPowuI1ZXoB7+RVfgD6+5dsbR3iZgAAAABJRU5ErkJggg== In-Reply-To: <8736nbip4l.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 25 Mar 2019 03:55:54 +0000") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234718 Archived-At: "Basil L. Contovounesios" writes: > + (unless (or (gnus-data-pseudo-p datum) > + (<= (gnus-data-number datum) 0) I'm against using `unless' on complex logic -- many people get confused when reading it in my experience. The rest looks OK. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no