New faces in iswitchb

New faces in iswitchb

[Kim F. Storm]

Re. the following change,

2005-06-04  Matt Hodges  <MPHodges@member.fsf.org>

	* iswitchb.el (iswitchb-single-match-face)
	(iswitchb-current-match-face, iswitchb-virtual-matches-face)
	(iswitchb-invalid-regexp-face): New faces.

we generally try to avoid naming faces with -face suffix, as they have
their own namespace.  Pls. change the new face names accordingly.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: New faces in iswitchb

[Matt Hodges]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

>>>>> Kim Storm writes:

 > we generally try to avoid naming faces with -face suffix, as they
 > have their own namespace.  Pls. change the new face names
 > accordingly.

Sorry, I should have been aware of this.  Is it mentioned somewhere?
I couldn't find it in (info "(elisp)Coding Conventions."), for
example.

Can someone install the attached?

Thanks,

Matt


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: iswitchb.el patch. --]
[-- Type: text/x-patch, Size: 2018 bytes --]

Index: lisp/iswitchb.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/iswitchb.el,v
retrieving revision 1.57
diff -u -r1.57 iswitchb.el
--- lisp/iswitchb.el	4 Jun 2005 19:10:07 -0000	1.57
+++ lisp/iswitchb.el	6 Jun 2005 13:10:47 -0000
@@ -404,21 +404,21 @@
   :type 'hook
   :group 'iswitchb)
 
-(defface iswitchb-single-match-face
+(defface iswitchb-single-match
   '((t
      (:inherit font-lock-comment-face)))
   "Iswitchb face for single matching buffer name."
   :version "22.1"
   :group 'iswitchb)
 
-(defface iswitchb-current-match-face
+(defface iswitchb-current-match
   '((t
      (:inherit font-lock-function-name-face)))
   "Iswitchb face for current matching buffer name."
   :version "22.1"
   :group 'iswitchb)
 
-(defface iswitchb-virtual-matches-face
+(defface iswitchb-virtual-matches
   '((t
      (:inherit font-lock-builtin-face)))
   "Iswitchb face for matching virtual buffer names.
@@ -426,7 +426,7 @@
   :version "22.1"
   :group 'iswitchb)
 
-(defface iswitchb-invalid-regexp-face
+(defface iswitchb-invalid-regexp
   '((t
      (:inherit font-lock-warning-face)))
   "Iswitchb face for indicating invalid regexp. "
@@ -1299,9 +1299,9 @@
 	  (put-text-property 0 (length first) 'face
 			     (if (= (length comps) 1)
                                  (if iswitchb-invalid-regexp
-                                     'iswitchb-invalid-regexp-face
-                                   'iswitchb-single-match-face)
-			       'iswitchb-current-match-face)
+                                     'iswitchb-invalid-regexp
+                                   'iswitchb-single-match)
+			       'iswitchb-current-match)
 			     first)
 	  (setq comps  (cons first (cdr comps)))))
 
@@ -1330,7 +1330,7 @@
 	(let ((comp comps))
 	  (while comp
 	    (put-text-property 0 (length (car comp))
-			       'face 'iswitchb-virtual-matches-face
+			       'face 'iswitchb-virtual-matches
 			       (car comp))
 	    (setq comp (cdr comp))))))
 

[-- Attachment #3: ChangeLog entry. --]
[-- Type: text/plain, Size: 82 bytes --]

2005-06-06  Matt Hodges  <MPHodges@member.fsf.org>

	* iswitchb.el: Rename faces.

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: New faces in iswitchb

[Kim F. Storm]

Matt Hodges <MPHodges@member.fsf.org> writes:

>>>>>> Kim Storm writes:
>
>  > we generally try to avoid naming faces with -face suffix, as they
>  > have their own namespace.  Pls. change the new face names
>  > accordingly.
>
> Sorry, I should have been aware of this.  Is it mentioned somewhere?
> I couldn't find it in (info "(elisp)Coding Conventions."), for
> example.

I don't know -- anyone?

>
> Can someone install the attached?

Done.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: New faces in iswitchb

[Richard Stallman]

    Sorry, I should have been aware of this.  Is it mentioned somewhere?
    I couldn't find it in (info "(elisp)Coding Conventions."), for
    example.

I will document it under defface.