From: storm@cua.dk (Kim F. Storm)
Subject: Please review: Small fix for window.c
Date: Wed, 08 Mar 2006 16:52:54 +0100 [thread overview]
Message-ID: <m3ek1dc4rt.fsf@kfs-l.imdomain.dk> (raw)
Since any non-nil value for set-window-dedicated-p means window
is dedicated, testing explicitly for Qt seems like a bug...
*** window.c 28 Feb 2006 16:57:34 +0100 1.537
--- window.c 08 Mar 2006 16:49:11 +0100
***************
*** 2009,2015 ****
`obj & 1' means consider only full-width windows.
`obj & 2' means consider also dedicated windows. */
if (((XINT (obj) & 1) && !WINDOW_FULL_WIDTH_P (w))
! || (!(XINT (obj) & 2) && EQ (w->dedicated, Qt))
/* Minibuffer windows are always ignored. */
|| MINI_WINDOW_P (w))
break;
--- 2009,2015 ----
`obj & 1' means consider only full-width windows.
`obj & 2' means consider also dedicated windows. */
if (((XINT (obj) & 1) && !WINDOW_FULL_WIDTH_P (w))
! || (!(XINT (obj) & 2) && !NILP (w->dedicated))
/* Minibuffer windows are always ignored. */
|| MINI_WINDOW_P (w))
break;
***************
*** 2064,2070 ****
case GET_LARGEST_WINDOW:
{ /* nil `obj' means to ignore dedicated windows. */
/* Ignore dedicated windows and minibuffers. */
! if (MINI_WINDOW_P (w) || (NILP (obj) && EQ (w->dedicated, Qt)))
break;
if (NILP (best_window))
--- 2064,2070 ----
case GET_LARGEST_WINDOW:
{ /* nil `obj' means to ignore dedicated windows. */
/* Ignore dedicated windows and minibuffers. */
! if (MINI_WINDOW_P (w) || (NILP (obj) && !NILP (w->dedicated)))
break;
if (NILP (best_window))
next reply other threads:[~2006-03-08 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 15:52 Kim F. Storm [this message]
2006-03-08 16:11 ` Please review: Small fix for window.c Stefan Monnier
2006-03-08 20:23 ` Kim F. Storm
2006-03-09 4:48 ` Miles Bader
2006-03-09 17:14 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2006-03-09 7:52 klaus.berndl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ek1dc4rt.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).