unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* url-http.el: error for redirected proxy connections
@ 2006-12-07 14:42 Klaus Straubinger
  2006-12-08  0:46 ` Magnus Henoch
  0 siblings, 1 reply; 2+ messages in thread
From: Klaus Straubinger @ 2006-12-07 14:42 UTC (permalink / raw)


The change

|	* url-http.el (url-http): Make proxy-object buffer-local, to
|	handle proxied asynchronous connections correctly.

introduced a problem when the URL package tries to fetch a redirected
URL trough a proxy connection. The function url-http-create-request has
not the correct value of the variable proxy-object to extract the host
name in this case, resulting in an error message.

Simply leaving out the line

	(make-local-variable 'proxy-object)

in function url-http did solve the problem for me.

The above mentioned correction introduced this line; its purpose had
not been clear to me because proxy-object is only used dynamically
and does not belong to a buffer, as far as I can see.

-- 
Klaus Straubinger

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: url-http.el: error for redirected proxy connections
  2006-12-07 14:42 url-http.el: error for redirected proxy connections Klaus Straubinger
@ 2006-12-08  0:46 ` Magnus Henoch
  0 siblings, 0 replies; 2+ messages in thread
From: Magnus Henoch @ 2006-12-08  0:46 UTC (permalink / raw)


Klaus Straubinger <KSNetz@UseNet.ArcorNews.DE> writes:

> The change
>
> |	* url-http.el (url-http): Make proxy-object buffer-local, to
> |	handle proxied asynchronous connections correctly.
>
> introduced a problem when the URL package tries to fetch a redirected
> URL trough a proxy connection. The function url-http-create-request has
> not the correct value of the variable proxy-object to extract the host
> name in this case, resulting in an error message.
>
> Simply leaving out the line
>
> 	(make-local-variable 'proxy-object)
>
> in function url-http did solve the problem for me.

That line was introduced because of my ignorance of the unfruitful
interactions of let bindings and buffer-local variables...

> The above mentioned correction introduced this line; its purpose had
> not been clear to me because proxy-object is only used dynamically
> and does not belong to a buffer, as far as I can see.

"Not clear" is indeed an accurate description.  I have now simplified
the code (in particular url-http-create-request), and it seems that
proxies and target URLs are now passed along properly.

Magnus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-08  0:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-07 14:42 url-http.el: error for redirected proxy connections Klaus Straubinger
2006-12-08  0:46 ` Magnus Henoch

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).