From: Tom Tromey <tromey@redhat.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: autoconf bcopy and bzero
Date: Sat, 26 Jan 2008 12:23:39 -0700 [thread overview]
Message-ID: <m3ejc4l7b8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200801261953.m0QJrD8O022596@sallyv1.ics.uci.edu> (Dan Nicolaescu's message of "Sat\, 26 Jan 2008 11\:53\:13 -0800")
>> One way to get rid of the warning is to '#undef bcopy' before defining
>> it. Alternatively, the code could read:
>>
>> #if !defined HAVE_BCOPY && !defined bcopy
>> #define bcopy(a,b,s) memcpy (b,a,s)
>> #endif
Dan> That's the obvious think to do, but is it correct?
I don't think there is a really correct answer. IMO these can't hurt,
and they should always give a working result. For things I maintain,
that would be good enough; I don't know what the Emacs approach is
here.
Using bcopy et al is a bit funny. Most other projects I follow moved
to the mem* functions years ago. This is very minor, though, I
suppose.
Tom
prev parent reply other threads:[~2008-01-26 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 18:33 autconf bcopy and bzero Dan Nicolaescu
2008-01-26 18:54 ` Tom Tromey
2008-01-26 19:53 ` autoconf " Dan Nicolaescu
2008-01-26 19:23 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ejc4l7b8.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).