From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Revamping sit-for [Was: Lingering input pending with motif menu bar] Date: Mon, 10 Jul 2006 14:10:30 +0200 Message-ID: References: <87mzbl3wrd.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1152533569 10731 80.91.229.2 (10 Jul 2006 12:12:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Jul 2006 12:12:49 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 10 14:12:46 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fzucy-0007CL-J4 for ged-emacs-devel@m.gmane.org; Mon, 10 Jul 2006 14:12:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fzucw-0005nV-Gz for ged-emacs-devel@m.gmane.org; Mon, 10 Jul 2006 08:12:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fzucl-0005lc-Tw for emacs-devel@gnu.org; Mon, 10 Jul 2006 08:12:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fzucj-0005lN-CR for emacs-devel@gnu.org; Mon, 10 Jul 2006 08:12:27 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fzucj-0005lK-9k for emacs-devel@gnu.org; Mon, 10 Jul 2006 08:12:25 -0400 Original-Received: from [195.41.46.237] (helo=pfepc.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fzudn-0007f3-RI; Mon, 10 Jul 2006 08:13:31 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepc.post.tele.dk (Postfix) with SMTP id EAF528A0065; Mon, 10 Jul 2006 14:12:18 +0200 (CEST) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Sun, 09 Jul 2006 15:03:02 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:56885 Archived-At: Richard Stallman writes: > Can you give a _precise_ description of what behaviour of the old sit-for > is "lost" in the new sit-for. > > I don't have one, because that behavior was never designed. It was a > bug. It arose in the 90s as an unintended consequence of the > existence of events (I think even X events) that the user would never > see. > > I think the behavior is that internal events can appear in the queue > and cause sit-for to return, but then no input is really available. > > Chances are that this behavior causes nothing but bugs, and that all > callers will benefit from the correction of it. However, I think we > ought to check the callers, so as to make sure we don't introduce any > new bugs by this change. It would be useful to know exactly what events will no longer make sit-for return -- then we could grep for those events and see if any lisp code uses sit-for to wait for one of those events. That would be a much more directed effort than trying to understand each of the 534 calls to sit-for. BTW, will "help-echo" events still make the new sit-for return? Chong, could you post a genuine patch with your changes. Thanks. -- Kim F. Storm http://www.cua.dk