From: Andreas Schwab <schwab@linux-m68k.org>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: Allow specifying services as symbols?
Date: Wed, 20 Oct 2010 13:52:11 +0200 [thread overview]
Message-ID: <m3d3r5f5ec.fsf@hase.home> (raw)
In-Reply-To: <87fww1je0d.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 20 Oct 2010 06:32:34 -0500")
Ted Zlatanov <tzz@lifelogs.com> writes:
> @@ -3303,6 +3304,11 @@
> Otherwise, use getservbyname to lookup the service. */
> if (!NILP (host))
> {
> + /* Take a symbol as the service and convert it to a string. */
> + if (!NILP (service) && !EQ (service, Qt) && SYMBOLP (service))
> + {
> + service = Fsymbol_name (service);
> + }
>
> /* SERVICE can either be a string or int.
> Convert to a C string for later use by getaddrinfo. */
Why not just move the hunk down to where service is checked for being a
string?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2010-10-20 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 18:07 Allow specifying services as symbols? Lars Magne Ingebrigtsen
2010-10-19 18:22 ` Eli Zaretskii
2010-10-19 19:09 ` Ted Zlatanov
2010-10-19 20:17 ` Chong Yidong
2010-10-19 21:25 ` Ted Zlatanov
2010-10-19 21:32 ` Davis Herring
2010-10-19 22:20 ` Chong Yidong
2010-10-19 23:46 ` Lars Magne Ingebrigtsen
2010-10-20 15:36 ` Stefan Monnier
2010-10-20 16:10 ` Chong Yidong
2010-10-20 16:21 ` Ted Zlatanov
2010-10-20 11:32 ` Ted Zlatanov
2010-10-20 11:52 ` Andreas Schwab [this message]
2010-10-20 12:29 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3r5f5ec.fsf@hase.home \
--to=schwab@linux-m68k.org \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).