From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: ImageMagick support on Cygwin Date: Mon, 23 Aug 2010 15:56:07 +0200 Message-ID: References: <4C6DB4F8.9090003@alice.it> <8339u9r72y.fsf@gnu.org> <4C6F00AE.40500@alice.it> <4C7246A8.80906@alice.it> <4C725C89.8000209@alice.it> <4C7266B4.4010009@alice.it> <4C727B9E.50407@cornell.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1282571795 13666 80.91.229.12 (23 Aug 2010 13:56:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 23 Aug 2010 13:56:35 +0000 (UTC) Cc: Angelo Graziosi , Andreas Schwab , "emacs-devel@gnu.org" To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 23 15:56:33 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OnXVk-000411-4Y for ged-emacs-devel@m.gmane.org; Mon, 23 Aug 2010 15:56:28 +0200 Original-Received: from localhost ([127.0.0.1]:58654 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnXVj-0001Bj-Ao for ged-emacs-devel@m.gmane.org; Mon, 23 Aug 2010 09:56:27 -0400 Original-Received: from [140.186.70.92] (port=51688 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnXVZ-0001A4-Lk for emacs-devel@gnu.org; Mon, 23 Aug 2010 09:56:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnXVU-00047Y-0I for emacs-devel@gnu.org; Mon, 23 Aug 2010 09:56:17 -0400 Original-Received: from smtprelay-h31.telenor.se ([213.150.131.4]:51729) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnXVT-00046s-Mx for emacs-devel@gnu.org; Mon, 23 Aug 2010 09:56:11 -0400 Original-Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-h31.telenor.se (Postfix) with ESMTP id DC583E9F36 for ; Mon, 23 Aug 2010 15:56:09 +0200 (CEST) X-SENDER-IP: [83.227.138.150] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoI9AEcbckxT44qWPGdsb2JhbACDF4RSmEQMAQEBATUtqHaRX4EigyJzBIl2gn2HSA X-IronPort-AV: E=Sophos;i="4.56,257,1280700000"; d="scan'208";a="122513785" Original-Received: from ua-83-227-138-150.cust.bredbandsbolaget.se (HELO www.verona.se) ([83.227.138.150]) by ipb1.telenor.se with ESMTP; 23 Aug 2010 15:56:09 +0200 Original-Received: from localhost.localdomain (unknown [192.168.201.6]) by www.verona.se (Postfix) with ESMTP id CDD5B47663; Mon, 23 Aug 2010 15:56:07 +0200 (CEST) In-Reply-To: <4C727B9E.50407@cornell.edu> (Ken Brown's message of "Mon, 23 Aug 2010 09:46:06 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:129083 Archived-At: Ken Brown writes: > On 8/23/2010 8:48 AM, joakim@verona.se wrote: >> Angelo Graziosi writes: >> >>> Il 23/08/2010 14.07, joakim@verona.se ha scritto: >>>> Angelo Graziosi writes: >>>> >>>>> Il 23/08/2010 12.51, joakim@verona.se ha scritto: >>>>>> Angelo Graziosi writes: >>>>>> >>>>>>> Il 21/08/2010 8.55, joakim@verona.se ha scritto: >>>>>>>> Angelo Graziosi writes: >>>>>>>> >>>>>>>>> joakim wrote: >>>>>>>>>> This analysis is probably correct. I'll try to check in a fix. >>>>>>>>> >>>>>>>>> Rev. 101149 still fails in the same manner. And these warnings >>>>>>>>> >>>>>>>>> [...] >>>>>>>>> /tmp/emacs/src/image.c: In function =E2=80=98imagemagick_load_ima= ge=E2=80=99: >>>>>>>>> /tmp/emacs/src/image.c:7663:11: warning: passing argument 2 of >>>>>>>>> =E2=80=98PixelGetNextIteratorRow=E2=80=99 from incompatible point= er type [enabled by >>>>>>>>> default] >>>>>>>>> /usr/include/ImageMagick/wand/pixel-iterator.h:55:5: note: expect= ed >>>>>>>>> =E2=80=98long unsigned int *=E2=80=99 but argument is of type =E2= =80=98size_t *=E2=80=99 >>>>>>>>> /tmp/emacs/src/image.c:7715:7: warning: implicit declaration of >>>>>>>>> function =E2=80=98MagickExportImagePixels=E2=80=99 [-Wimplicit-fu= nction-declaration] >>>>>>>>> /tmp/emacs/src/image.c: In function =E2=80=98Fimagemagick_types= =E2=80=99: >>>>>>>>> /tmp/emacs/src/image.c:7835:3: warning: passing argument 2 of >>>>>>>>> =E2=80=98GetMagickList=E2=80=99 from incompatible pointer type [e= nabled by default] >>>>>>>>> /usr/include/ImageMagick/magick/magick.h:87:5: note: expected =E2= =80=98long >>>>>>>>> unsigned int *=E2=80=99 but argument is of type =E2=80=98size_t *= =E2=80=99 >>>>>>>>> [...] >>>>>>>>> >>>>>>>>> are not too reassuring... >>>>>>>> >>>>>>>> I'll try to set up a cygwin environment here. That will take a whi= le. >>>>>>> >>>>>>> Sorry, but this issue is not Cygwin specific at all: I think you >>>>>>> should setup also a GNU/Linux Kubuntu 8.04 system, on which there a= re >>>>>>> the *same* identical problems that occur on Cygwin. On K804 >>>>>>> imagemagick is 6.3.7. >>>>>> >>>>>> Ok, I will download a vbox image and set up ubuntu 8.04. >>>>>> >>>>>> BTW the warnings seem to stem from some api change. I'll figure out = some >>>>>> solution for that also. >>>>> >>>>> The main problem is that bootstrap fails because the 'logic' in >>>>> configure.in looks wrong in any case, as pointed out by Ken. >>>>> >>>>> If on Kubuntu 10.04 (the last Kubuntu) the bootstrap works, it happens >>>>> _ONLY_ because the ImageMagick is more recent and, accidentally, has >>>>> MagickExport.. defined. >>>> >>>> Does bootstrap fail even if you dont --enable-imagemagick? >>> >>> The bootstrap DOES NOT fail if: >>> >>> 1. imagemagick support is disabled, i.e. if one DOES NOT add >>> --with-imagemagick' to configure >>> >>> 2. if 'AC_DEFINE(HAVE_MAGICKEXPORTIMAGEPIXELS, 0, [Define to 1 if >>> MagickExportImagePixels is defined.])' is removed by configure.in and >>> configure is regenereated (calling autoconf) >> >> >> Thanks for this clarification. >> >>> It seems I am repeating my self or you do not read carefully what me >>> and Ken are writing... >> >> Sorry, I have only limited powers of comprehension. >> >> Anyway, I have pushed a patch that removes the AC_DEFINE to the >> imagemagick branch, and tested it on my development environment. I will >> merge this fix to trunk in a while. > > It looks like Andreas has already done this (r 101171). Yes, I noticed. Thanks Andreas! > > Ken > --=20 Joakim Verona