unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: nicolas@petton.fr, emacs-devel@gnu.org, tino.calancha@gmail.com
Subject: Re: Add autoload cookies in seq.el
Date: Thu, 21 Jul 2016 17:01:29 +0200	[thread overview]
Message-ID: <m3bn1ryr06.fsf@gnus.org> (raw)
In-Reply-To: <834m7jysab.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Jul 2016 17:33:48 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> > Lars, why did you put read-multiple-choice in subr.el?  Its only user
>> > currently is message.el, which is not preloaded, so I think preloading
>> > seq.el as result of this is not justified.
>> 
>> Perhaps subr-x.el would be a better place for it...
>> 
>> But I find it rather odd that we can't use the best and most modern
>> libraries in the most central parts of Emacs.  That's kinda backwards.
>> The most central parts of Emacs gets the most obfuscated code?
>
> IOW, from my POV some code which was only used by message.el (which is
> not preloaded, and was never supposed to be) was added to subr.el,
> which then required to preload seq.el.  How is that related to the
> following complaint of yours:

I changed subject between the first and second paragraphs.

> Maybe I'm misremembering, but I only saw discussions about preloading
> seq once or twice, including this discussion.  So I'm not sure where
> does "persona non grata" thing come from.  Can you point me to those
> incidents which led you to this conclusion?

commit 9c969e1f848e65b24e06d3919cde9a7ae668bfb8
Author: Glenn Morris <rgm@gnu.org>
Date:   Mon May 23 12:48:19 2016 -0400

    * lisp/image.el (image--get-image): Avoid requiring a library for
    one trivial operation.

commit c6493c68f8fd6a5e6893eb3837a1a27f8d8a98a8
Author: Paul Eggert <eggert@cs.ucla.edu>
Date:   Mon May 23 08:13:03 2016 -0700

    Fix seq requirement that broke bootstrap
    
    * lisp/image.el (image--get-image): Require seq here, not at the
    top level, to avoid ‘(require seq) while preparing to dump’ while
    bootstrapping.  Suggested by Tino Calancha in:
    http://lists.gnu.org/archive/html/emacs-devel/2016-05/msg00477.html

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2016-07-21 15:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20  6:06 Add autoload cookies in seq.el Tino Calancha
2016-05-20  8:26 ` Nicolas Petton
2016-05-20  8:54   ` Tino Calancha
2016-05-20  9:42     ` Eli Zaretskii
2016-05-21  0:07       ` Tino Calancha
2016-05-21  6:50         ` Eli Zaretskii
2016-07-20 13:24           ` Lars Ingebrigtsen
2016-07-20 15:13             ` Eli Zaretskii
2016-07-21 10:51               ` Lars Ingebrigtsen
2016-07-21 13:27                 ` Ted Zlatanov
2016-07-21 14:38                   ` Eli Zaretskii
2016-07-21 14:33                 ` Eli Zaretskii
2016-07-21 15:01                   ` Lars Ingebrigtsen [this message]
2016-07-21 16:09                     ` Eli Zaretskii
2016-07-22  9:04                       ` Lars Ingebrigtsen
2016-07-22 10:50                         ` Ted Zlatanov
2016-07-21 14:36                 ` Michael Heerdegen
2016-07-21 15:45                   ` Stefan Monnier
2016-07-22 14:26                     ` Stefan Monnier
2016-07-22 15:07                       ` Nicolas Petton
2016-07-22 15:18                         ` Stefan Monnier
2016-07-22 15:28                         ` Eli Zaretskii
2016-07-22 17:48                           ` Nicolas Petton
2016-05-22 12:17   ` Tino Calancha
2016-05-22 19:54     ` Nicolas Petton
2016-05-23  1:49       ` Tino Calancha
2016-05-23  8:33         ` Nicolas Petton
2016-05-23 15:13         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3bn1ryr06.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=nicolas@petton.fr \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).