From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build Date: Sun, 09 Jun 2019 16:53:50 +0200 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="31172"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eli Zaretskii , Noam Postavsky , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 09 16:54:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZzDi-0007yL-6l for ged-emacs-devel@m.gmane.org; Sun, 09 Jun 2019 16:54:54 +0200 Original-Received: from localhost ([::1]:36218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZzDg-00061u-OZ for ged-emacs-devel@m.gmane.org; Sun, 09 Jun 2019 10:54:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34266) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZzCp-0005xn-9P for emacs-devel@gnu.org; Sun, 09 Jun 2019 10:54:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZzCo-0001N1-AY for emacs-devel@gnu.org; Sun, 09 Jun 2019 10:53:59 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:39118) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZzCo-0001Kz-40; Sun, 09 Jun 2019 10:53:58 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZzCh-00042K-57; Sun, 09 Jun 2019 16:53:53 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEUQDw8NCwwODQ4IBwgR EBBCQUAYFxbj4+MNDA0DAgNaJaBfAAACaElEQVQ4jXWTQW8aMRCFRysnXGvIYY+OG5q9olSVcltF BnJM0wXvkSJge0wlvHNlV6rqOyf+bZ+9hLRJ+g7IzMfMmxkb2vyr2VEFbd7XioyZrP4DoMn7IA9o jcKvQShnOWj+OiPEZzN8uGewCKAVlmOZtT3lRHBZ8Tz2sNlYfgEoxE6YTmsUiy0uKSeqeLHLT6QI mQCJFrz1fUV517it4w8COOPvstUq5KLzKceJl6S1rRv5a66ByMxgWIQ2lqQUl3L022Ue5JxzY7dd RjLke5n2nPctlsI5TZ0RwSMbOinTa9ekOqwlV2MOZsiY1lK2PZdpNQuADK+EEDC3P0etvnZwMADo yxax3cx+G/U9gFYCwAV37GlB3n6Vfd0D0AFgimp7FUDG5SBtAyCB1c8DMAG0/GMAj1rrRMAWsekJ eMyWoJQygkg8A81l6qEW60qS0NuxlLalj0B3om4nKGVLmfrM+yzTGDJXAnOIAKonbCmLKb4dPqCF 4k6LBe2mdXLFj/CAi7A1TXiFtAWpsUuUdbrV3itcRj6ON4XJP/ESl/gIG60rzkXlOpAq+4RluAXm WHOdi9iUWZH0FdZxhpe4ngHTOF6tKcj7IS+zXRXfLmJdpQjwGrRHGXYrSs55a3LsBaBJe1yGMYhU sF/hHSlRkEybC3aXuPcGV3zGdaKxUAUA/WLXyOPhvtmZu2cgLbtSyj58HpqmbxJ99dAB2f2h0Fb4 0rZZ8BjcQKN1CIe0qOaiIMRHEU3mS3kTTyfwRqPRERz2h6A9jreHiD4D3B5eC+BLQW/CkfwN9qfD KWP/8tv94HB58+EjwB/D3mRWN2M8fgAAAABJRU5ErkJggg== In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 09 Jun 2019 15:48:03 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237345 Archived-At: I'm working my way through the different byte compilation warnings, and suppressing is usually trivial. But then there's this: (defun cconv--analyze-use (vardata form varkind) "Analyze the use of a variable. [...] (unless (or ;; Uninterned symbols typically come from macro-expansion, so ;; it is often non-trivial for the programmer to avoid such ;; unused vars. (not (intern-soft var)) (eq ?_ (aref (symbol-name var) 0)) ;; As a special exception, ignore "ignore". (eq var 'ignored)) (byte-compile-warn "Unused lexical %s `%S'" varkind var))) It does not use `byte-compile-warning-enabled-p' at all -- is that a bug? It should be able to suppress those via `byte-compile-warnings', right? But I can't really see any practical way of using `with-suppressed-warnings' here... Unless... (with-suppressed-warnings ((unused foo)) (defun bar (foo) nil)) ? Looks kinda janky. Perhaps a `declare' would be more sensible. Or not being able to use `with-suppressed-warnings' here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no