From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: JUAN-LEON Lahoz Garcia Newsgroups: gmane.emacs.devel Subject: Re: wdired.el cleanup Date: Tue, 12 Apr 2005 10:23:47 +0200 Message-ID: References: NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1113295360 7001 80.91.229.2 (12 Apr 2005 08:42:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 12 Apr 2005 08:42:40 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 12 10:42:37 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DLGxp-0001te-L0 for ged-emacs-devel@m.gmane.org; Tue, 12 Apr 2005 10:41:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DLGY5-0000mw-UZ for ged-emacs-devel@m.gmane.org; Tue, 12 Apr 2005 04:15:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DLGR0-0007Se-50 for emacs-devel@gnu.org; Tue, 12 Apr 2005 04:07:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DLGQx-0007SQ-1U for emacs-devel@gnu.org; Tue, 12 Apr 2005 04:07:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DLGK2-0007A2-9u for emacs-devel@gnu.org; Tue, 12 Apr 2005 04:00:35 -0400 Original-Received: from [144.189.100.102] (helo=motgate4.mot.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DLGYR-00067a-En for emacs-devel@gnu.org; Tue, 12 Apr 2005 04:15:28 -0400 Original-Received: from az33exr04.mot.com (az33exr04.mot.com [10.64.251.234]) by motgate4.mot.com (8.12.11/Motgate4) with ESMTP id j3C8KQ36007114 for ; Tue, 12 Apr 2005 01:20:26 -0700 (MST) Original-Received: from zes06exm01.madrid.ecid.cig.mot.com ([10.161.1.12]) by az33exr04.mot.com (8.13.1/8.13.0) with ESMTP id j3C8GfZt013986 for ; Tue, 12 Apr 2005 03:16:42 -0500 (CDT) Original-Received: from kaliban.madrid.ecid.cig.mot.com.motorola.com (10.161.14.31 [10.161.14.31]) by zes06exm01.madrid.ecid.cig.mot.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2657.72) id FGJD2842; Tue, 12 Apr 2005 10:15:15 +0200 Original-To: Stefan Monnier In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.50.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:35893 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35893 >>>>> "Stefan" == Stefan Monnier writes: > >> [ PS. Is there any reason not to bind C-x C-q in dired-mode-map by >> default to wdired-change-to-wdired-mode? IMHO this key combination >> is not easy to accidentally hit for wdired unaware users, but easy >> to remember for wdired aware users ]. > > IIRC using C-x C-q is indeed the intention. > I can't remembr why I didn't do it at the time, maybe I just got > side-tracked. I do remember there were questions about the wdired->dired > direction where users might want to be able to just make the buffer > read-only with C-x C-q without wanting to "commit" the changes. Right now, in wdired mode, successive C-x C-q hist make the buffer to switch between read only and writable states. If this has no sense, C-x C-q can be bind by default (in dired-mode-map) to wdired-abort-changes (to abort), to wdired-finish-edit (to commit) or to ignore (to avoid confusion). > PS: I installed your patch, except for the mistaken change from > wdired-mode-hook to wdired-mode-hooks. Oooops! Thank you very much -- juanleon