From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] left-fringe for speedbar Date: Mon, 14 Nov 2005 15:16:41 +0100 Message-ID: References: <17270.27018.323474.12554@kahikatea.snap.net.nz> <17270.43696.230430.614277@kahikatea.snap.net.nz> <17271.48554.199488.298170@kahikatea.snap.net.nz> <17271.59317.835631.55911@kahikatea.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1131980091 5977 80.91.229.2 (14 Nov 2005 14:54:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 14 Nov 2005 14:54:51 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 14 15:54:39 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EbfhZ-0004RP-Qr for ged-emacs-devel@m.gmane.org; Mon, 14 Nov 2005 15:52:58 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EbfhZ-0007SP-9O for ged-emacs-devel@m.gmane.org; Mon, 14 Nov 2005 09:52:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ebf9R-0004Mi-5E for emacs-devel@gnu.org; Mon, 14 Nov 2005 09:17:41 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ebf9P-0004Ln-7H for emacs-devel@gnu.org; Mon, 14 Nov 2005 09:17:40 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ebf9O-0004Le-8o for emacs-devel@gnu.org; Mon, 14 Nov 2005 09:17:38 -0500 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ebf9O-0005Qh-3w for emacs-devel@gnu.org; Mon, 14 Nov 2005 09:17:38 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepa.post.tele.dk (Postfix) with SMTP id DC6AE47FECD; Mon, 14 Nov 2005 15:17:36 +0100 (CET) Original-To: Nick Roberts In-Reply-To: <17271.59317.835631.55911@kahikatea.snap.net.nz> (Nick Roberts's message of "Mon, 14 Nov 2005 14:26:13 +1300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:45953 Archived-At: Nick Roberts writes: > > The problem seems to be that update_tool_bar only sets the current buffer > > to the buffer of the selected window of the frame being updated, but > > keeps the selected window (and selected frame) unchanged, so any functions > > used by the tool-bar menu-items will refer to the wrong info. > > > > We could fix this (by changing frame/window temporarily while updating > > the tool bar [and menu bar?], or we could make new variables > > tool-bar-updating-frame and tool-bar-updating-window which are > > exported from C to Lisp to be used explicitly in such cases where a > > tool-bar item should reflect the hosting frame/window rather than the > > selected frame/window. > > > > WDYT? > > I think that the former would be best. I don't see any need to configure the > behaviour with lisp variables. By "we" I hope you mean you, as I haven't > got a clue about how to do it! Problem is that I don't know what other code may be broken by this change. In any case, why not just always show the STOP/GO/UNTIL icons, even when there is a fringe. They don't harm -- and for the novice, they are less cryptic than clicking on the fringe. BTW, I still totally dislike the current STOP/GO icons -- they don't stop or go, they set or clears a breakpoint. As such "stop" should show a (solid) red circle, and the "go" should be the same circle with a big X over it. WDYT? -- Kim F. Storm http://www.cua.dk