From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: James Cloos Newsgroups: gmane.emacs.devel Subject: Re: Icon displayed wrong Date: Sat, 19 May 2007 05:10:49 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1179565920 23218 80.91.229.12 (19 May 2007 09:12:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 19 May 2007 09:12:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 19 11:11:59 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HpKyg-0008C7-Se for ged-emacs-devel@m.gmane.org; Sat, 19 May 2007 11:11:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HpKye-00080o-Lq for ged-emacs-devel@m.gmane.org; Sat, 19 May 2007 05:11:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HpKyY-00080j-NL for emacs-devel@gnu.org; Sat, 19 May 2007 05:11:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HpKyU-00080X-Ik for emacs-devel@gnu.org; Sat, 19 May 2007 05:11:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HpKyU-00080U-CS for emacs-devel@gnu.org; Sat, 19 May 2007 05:11:42 -0400 Original-Received: from eagle.jhcloos.com ([207.210.242.212]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HpKyK-0007hK-O6; Sat, 19 May 2007 05:11:33 -0400 Original-Received: by eagle.jhcloos.com (Postfix, from userid 10) id 6651B40111; Sat, 19 May 2007 09:11:24 +0000 (UTC) DKIM-Signature: v=0.5; a=rsa-sha256; c=relaxed/relaxed; d=jhcloos.com; s=eagle; t=1179565884; bh=8jiFWZhKJO/8T7eaEBNq9PM8MRazpCnkdlHLRTNsq XE=; h=Received:From:To:Cc:Subject:In-Reply-To:References: User-Agent:Face:Copyright:OpenPGP:OpenPGP-Fingerprint:X-Hashcash: X-Hashcash:Date:Message-ID:Lines:MIME-Version:Content-Type; b=PBJs LU8sgJHmOSXT8enrcmShVZRdN1cn5T8LUmtelxi5cW0wRZvHs2OegCIe60XHN3Fy/FP 0ArwFynwXxRocopca70IzOYrN7CYyr41lQOCnRmll7Bgt9Jt+p0YKNjltF79ULvt/jL kPJexjOwqjCLWjKqnfd9optVC3LDu6ca8= Original-Received: by lugabout.jhcloos.org (Postfix, from userid 500) id E92EFEA01B; Sat, 19 May 2007 09:11:12 +0000 (UTC) In-Reply-To: (Eli Zaretskii's message of "Sat, 19 May 2007 11:16:50 +0300") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.0 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAMnRFWHRUaXRsZQAvbWF4dG9y L2Nsb29zL2luY29taW5nLzIwMDQvMDIvUFdHL0pIQzE2LnBuZyJMlEwAAAAadEVYdFNvZnR3YXJl AEdOT01FIEljb24gRWRpdG9ynioKbAAAAHFJREFUeJzFk8EKwCAMQ1/ED9cvzw6iuM0N9WIvDTWE 1KjAxmKnLBEBjLcEIBCeI2nccy5YKrjxwbbvAvZ37zlo4GB9iRMC/cq/AppItwmMyJ5I98wd9G7P xxgrSKlYS2lMrOcV13o95aVSKA7E5ndGXG+IIzcl4BNfAAAAAElFTkSuQmCC Copyright: Copyright 2007 James Cloos OpenPGP: ED7DAEA6; url=http://jhcloos.com/public_key/0xED7DAEA6.asc OpenPGP-Fingerprint: E9E9 F828 61A4 6EA9 0F2B 63E7 997A 9F17 ED7D AEA6 X-Hashcash: 1:23:070519:eliz@gnu.org::zhrJjZ6sShN+Sgen:000008Hmv X-Hashcash: 1:23:070519:emacs-devel@gnu.org::MlWS8RM4yckJlpug:0000000000000000000000000000000000000000015ucH Original-Lines: 45 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71377 Archived-At: >>>>> "Eli" == Eli Zaretskii writes: Eli> Note that there are a couple of other *.pbm files in etc/images Eli> that on the branch are not PBM files. For example, copy.pbm is a Eli> PPM file. Are we sure they all are due to typo-style mistakes? I see 5 such files: copy.pbm, next-node.pbm, prev-node.pbm, save.pbm and up-node.pbm. Each of those has just black and white pixels, exactly like the PGM version of cancel.pbm. So, yes, I do beleive they are also typo-style mistakes. It is very easy in the Gimp and XV to hit the wrong version of portable bit/grey/ pix map file when choosing from the popup menus. I've done it myself. The pbm icons were intended for bitmap displays (at least the ones coming from Gnus) and the xpm for colour displays. I do find it interesting that Emacs displays bitmap icons as foreground/ background masks rather than black/white images, but that does seem reasonable given the desires to support both light-on-dark and dark-on- light displays and to support bitmap displays of varying emitter colour. As such, the display of the unaltered cancel, copy, next-node, prev-node, save and up-node bitmap icons on light-on-dark bitmap displays will be drastically different than the rest of the bitmap icons. I can't see how that could have been intended. So those five should be converted with either of: ppmtopgm <$old |pgmtoppm >$new && mv $new $old convert $old -format PBM $new && mv $new $old >> If there is any chance of .990 getting simply renamed as 22.1 Eli> There's exactly 0% chance that this will happen, because some Eli> source files need to be modified to change the version number, and Eli> the ChangeLog files need to be marked with the release entry. OK. I did think that "other than release-process changes" went w/o saying, but point taken. -JimC -- James Cloos OpenPGP: 1024D/ED7DAEA6