unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Patch to change mouse binding for html view in gnus
Date: Thu, 12 Jul 2007 10:05:50 -0600	[thread overview]
Message-ID: <m3abu1ip41.fsf@fleche.redhat.com> (raw)
In-Reply-To: <b4md4z9krec.fsf@jpl.org> (Katsumi Yamaoka's message of "Wed\, 04 Jul 2007 08\:18\:35 +0900")

>>>>> "Katsumi" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

Katsumi> For this reason, I recommend using the function form
Katsumi> (lambda (url) (browse-url url) t)
Katsumi> rather than just using `browse-url'.

I tried:

(setq w3m-goto-article-function (lambda (url) (browse-url url) t))

but this fails:

  fboundp((lambda (url) (browse-url url) t))
  w3m-safe-view-this-url()
  w3m-mouse-safe-view-this-url((mouse-2 (#<window 1388 on *Article*> 436 (111 . 209) -81415166 nil 436 (18 . 16) nil (3 . 1) (6 . 13))))
  call-interactively(w3m-mouse-safe-view-this-url)

The reason is this code in w3m-safe-view-this-url:

     (url (or (when (fboundp w3m-goto-article-function)
		(funcall w3m-goto-article-function url))

So to make this work I had to make a new defun and then setq
w3m-goto-article-function to that.  Using an anonymous function won't
work, due to the fboundp.

I didn't look to see whether your patch here fixed this problem or
not, I just thought I'd post in case anybody else is trying to set
things up this way.

>> If you do all your browsing in Emacs then you probably already have
>> browse-url-browser-function set as you like...

Katsumi> I leave all those as the default and have no problem (Firefox
Katsumi> happens to be used by default).  I don't always necessarily use
Katsumi> emacs-w3m.   I use Firefox when purchasing something, manipulating
Katsumi> my bank account... ;-)

Ok.  I suppose this response means you are not swayed by my argument
that users should only have to customize in a single place.

Tom

  parent reply	other threads:[~2007-07-12 16:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-01 20:42 Patch to change mouse binding for html view in gnus Tom Tromey
2007-07-01 21:48 ` Reiner Steib
2007-07-01 21:43   ` Tom Tromey
2007-07-02  2:59     ` Katsumi Yamaoka
2007-07-02 17:29       ` Tom Tromey
2007-07-03  4:33         ` Katsumi Yamaoka
2007-07-03 17:19           ` Tom Tromey
2007-07-03 23:18             ` Katsumi Yamaoka
2007-07-04  6:10               ` Katsumi Yamaoka
2007-07-12 16:05               ` Tom Tromey [this message]
2007-07-12 18:19                 ` Stefan Monnier
2007-07-12 22:42                   ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3abu1ip41.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).