From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: epa-file Date: Sat, 18 May 2019 10:42:28 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="11124"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 10:42:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRuvT-0002lP-Nk for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 10:42:43 +0200 Original-Received: from localhost ([127.0.0.1]:59445 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRuvS-00082V-8r for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 04:42:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRuvL-00082P-DJ for emacs-devel@gnu.org; Sat, 18 May 2019 04:42:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRuvK-0006w8-DT for emacs-devel@gnu.org; Sat, 18 May 2019 04:42:35 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:50008) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRuvK-0006vY-6r for emacs-devel@gnu.org; Sat, 18 May 2019 04:42:34 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hRuvF-0006KQ-3k for emacs-devel@gnu.org; Sat, 18 May 2019 10:42:31 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUUGgcoKw8SDgNpZCoc IQw2NhQYSfM4AAACXklEQVQ4jXVTS3bjIBBECtqnHXov85QDJIQ9raC9Mer7X2WqpYnfZGbSfpZs iv5UFThfHyH4lq//7r/xI+ANeEqy4+HKW5m22yPFAMRnOiOX4MoXsGHhQFNPSRG/gR/aP37lljg1 4kSsmv7IkP2opmevb6XSB1am/i/wnaHzYy0g6jlQJaLoJIwHwWF8XfFehKyrLrOU8dBqjMO6RsSi 2lRllRaiFwOWOMbZC3XlrlR7bgsFA+I8jsuG7UQalmvPgZgAzIsbd9RHB2rctpTRTnfnoZlwRuuU GmsD/RCQ6qa9hoEzBkp48DO2t2rA0y6Mutrt0/V5S9oCMt3T+3ZsTpgVWqBHyqRW6nIl7gbwYQem xnhbcMM6czOl0RabG8qDxZmxbYRhbR3kiWoIwrtljMMzP4CAPU3Aw42HTRjGnMgggoY2LjJcNIoH gIl6ynxMdXcxCmY9rcsvoEmo6MYLtHWs6QFwA/tgLWDHoJmzAW9WxjNKuUP4gVUqd6gLZUkIpWw9 RlcHFk5amQQpCh7Tel3jQiR89GgvyQAYNd1f75HfVL8ATHXreXef78gAi/xyAnZUWkfzz3t0kT44 n/x2T6ZwglbWPATVM+Mm2jMlALXM0dewnRlpf1VjruQGqt67+gDgZ1twttxQtzZ73c6pMqzVLLDN TbfpFifki8JfteNlk6HUBbIbUIQgH5dGhyxuuywhXkG2Sql+IMF+sQy3Xvd4DS4U74PgEO52HAH4 eL1BxNkXH+xWDOa5ZpRaF/gxx6Hg5nu4iWuFI44btS6n8LM7vakUyPwo8a8476b8AssrvmAiL2Vx AAAAAElFTkSuQmCC In-Reply-To: (Lars Ingebrigtsen's message of "Fri, 17 May 2019 04:15:46 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236709 Archived-At: In epa-file-decode-and-insert: epa-file.el:109:22:Warning: =E2=80=98string-to-multibyte=E2=80=99 is an obs= olete function (as of 26.1); use =E2=80=98decode-coding-string=E2=80=99. Here's the code: (defun epa-file-decode-and-insert (string file visit beg end replace) (if (fboundp 'decode-coding-inserted-region) (save-restriction (narrow-to-region (point) (point)) (insert (if enable-multibyte-characters (string-to-multibyte string) string)) (decode-coding-inserted-region (point-min) (point-max) (substring file 0 (string-match epa-file-name-regexp file)) visit beg end replace)) (insert (epa-file--decode-coding-string string (or coding-system-for-re= ad 'undecided))))) Isn't that check for `enable-multibyte-characters' and call to `string-to-multibyte' completely superfluous? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no