From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: tags Date: Sun, 16 Jun 2019 15:20:02 +0200 Message-ID: References: <831rzvvsgp.fsf@gnu.org> <83y322vqvg.fsf@gnu.org> <83v9x6vpap.fsf@gnu.org> <52332265-2d02-a01c-e221-20b00b1edf86@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245227"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 16 15:21:56 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcV6X-0011fQ-U4 for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 15:21:54 +0200 Original-Received: from localhost ([::1]:39782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcV6W-0004VR-UA for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 09:21:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51655) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcV53-0004NX-34 for emacs-devel@gnu.org; Sun, 16 Jun 2019 09:20:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcV51-0003jo-6V for emacs-devel@gnu.org; Sun, 16 Jun 2019 09:20:20 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:49510) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcV4x-0003bj-7s for emacs-devel@gnu.org; Sun, 16 Jun 2019 09:20:15 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcV4k-00031q-Jt; Sun, 16 Jun 2019 15:20:04 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAIVBMVEUKDUgAAEsAAU36+ARM S0QAAE+ujyb//wAAAE3+/wjWxRnUA99JAAACNklEQVQ4jbXSQYvaQBQA4FFCK3sypYUcNegiPW3J krA5RXc6LZ5scMCjNdPZklMhxYAnIwbmuNBTb7aRCPmVfZNJXN312gdxzHy+vPG9oLvfL+JO7iE3 DHkRhnkRFnkBEeSw8jxDFtxk6nLlIr/LFTnx5fg/YOP7SxAxRMgFsD0ti6ML4IXPa8CVY0xevSge R3NdbzOtcJ7DTjeSZH4Vu+HhHIYSWnCgaE+yMzAEhKwRjbpPhOI9wEysA7hZDYVOnOOpvhoyJyFw 4BshfO1Qw6NQscZ8NBOztPdQwU9xGjSl00MFZXXRKj/TNKUTLVAwKLe+1yl0yr0HCUuMMSQtyu0+ pXQSu0HZK9nc4WZnqEcBFE5UQ/xD36knAfhZwfERkoYhjColiG9JDR/anxORrKEJAFpomzX8WUPG ZtQsy/sdTwGMdGG2NRKuVvNm3/fpxlSwul/x0FKpt32fUrOC5cmIIsZMUz4qsyzr1/lUbW8c5UiH QBrhYXauSDdUD990tNPJSpADlDHYdE8M6QPoJ4ULNPXNznG0bzH2MJ4ATBBu+NTUnAoYY5xxMsWe 6Gqe1zSvasCYzxmZcjaDsX4hDB1UjX4HaTAqzJmcN30f79XLoMtWz6A++ihPAbB4rUBK2Wz5ewnf PlVgXGPUkLtlRs9ZKGjo7SAuxgxpLeG/o+nE2akaNibQcCdys127t+/TrfO3ehMdq27qOHTng21c w9Mk4C8vzW18o8CCW5tzaLvMXBrXFfwDmRTVdnC3Ri4AAAAASUVORK5CYII= In-Reply-To: <52332265-2d02-a01c-e221-20b00b1edf86@yandex.ru> (Dmitry Gutov's message of "Sun, 16 Jun 2019 03:30:43 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237725 Archived-At: Dmitry Gutov writes: > FWIW, I believe tags-query-replace has an adequate replacement already > in the fileloop package (as you can see it's already implemented in > terms of it). That would take care of the last two warnings. Thanks; that was straightforward to rewrite... > esh-mode.el has a peculiar use for find-tag in creating a special > version of it that "ignores whether the text is read-only". I'm not > sure why that would matter since the command does not modify the > buffer contents. It's kinda puzzling. The comment in the key binding section is: ;; without this, find-tag complains about read-only text being ;; modified (if (eq (key-binding [(meta ?.)]) 'find-tag) (define-key eshell-mode-map [(meta ?.)] 'eshell-find-tag)) Perhaps this was somehow necessary in the year 2000 when it was written? > Should we just remove the command and the custom > binding? Not sure if eshell-mode just set up xref-find-functions as > well. Is it supposed to use a tags table, or find-func.el? I can't see any mention of xref in the eshell files... > As for viper, I guess the emulation stuff has some UI requrements? > Otherwise we could use xref-find-definitions and > xref-find-definitions-other-window there. The latter is fine, but the call for find-tag is with the next-p parameter: (if (string= tag "") (find-tag ex-tag t) (find-tag-other-window ex-tag)) How is that done in terms of xref? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no