From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: `message' not outputting the newline "atomically" Date: Mon, 24 Jun 2019 00:18:19 +0200 Message-ID: References: <83y31xr3aa.fsf@gnu.org> <26154872-1a5c-7302-0f32-b16aff8e0ae7@cs.ucla.edu> <83blytq90m.fsf@gnu.org> <95de57fb-ef8c-a65f-d3ca-4a9e7f0f38bc@cs.ucla.edu> <9f6382a8-4bb4-1018-fe18-ab01225bb4e4@cs.ucla.edu> <8df7509f-229e-3ce0-1d35-ab361467e4f9@grinta.net> <2987971e-9d16-0ec7-6474-55dc742afdff@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="128077"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Daniele Nicolodi , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 00:19:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfApA-000XBP-Sa for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 00:19:01 +0200 Original-Received: from localhost ([::1]:46974 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfAp9-0006gE-Tv for ged-emacs-devel@m.gmane.org; Sun, 23 Jun 2019 18:18:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41961) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfAoe-0006g6-Ld for emacs-devel@gnu.org; Sun, 23 Jun 2019 18:18:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfAoc-0002iT-Q9 for emacs-devel@gnu.org; Sun, 23 Jun 2019 18:18:28 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56494) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfAoa-0002fF-Rc for emacs-devel@gnu.org; Sun, 23 Jun 2019 18:18:25 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfAoV-0002mZ-QM; Mon, 24 Jun 2019 00:18:22 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEUoJy3T0tursb52iKE/ Wn7yWvCNAAACVklEQVQ4jUWU27HDIAxEdYECIuwCDLgAXgVgoP+a7gqcCR/ODMcraRccmms55oP3 cvuH5my0AOe1IU9bCgCVSgscHW8X/gHvN+BgTUwbZAFYG3Awev3aKoq1fHKhh0Ob3dl7plHr7DWU XHK1apdaU41S5ri9TcUVfo7hfuCeuTqbi8uYyqMKeyc+QkGPEFJOSvo6Do1oOIAbPbx1t18OPR9z LEUJs89v5SW55sy7VK8L1PJK1MqK58iisIWGgDPxAiPUMSbmONsLMtelcAUgPByJtH0kS+fcUoSR 65UsNTIHAAotMPuNHtFdZBCmgPIelIBKKGRuIml7vCAPKCT7hDaabX7ByGGMKsAdBSBQfkEoo00y hdSRorKmuW+6VUCqja70URiOf2BO1JFiH9PJcP8e1FKwxdaHFMz87alq2IAvxSdpMp+HbeyIfStC iX8AOKT4sEdhAejxYEcDXGj1d0hyM6GUof54d/FBBUBdBh2HnQMxmdGPitEeCfmCF7lXC1TdmgaQ sW9zu29zbUfL6phazoUyxp68DGKZorKL6SATpzE7EkPNVHwNeF9b5Gzw5szL4NLcky/y0F7pouFX iJ1qJF9Wb03TRBr38rG+kt40w6gc53aOQh0bSiNgsa4DHqPKuArFtY43lYa4UBCTlBOKicRNizmu Qs9pAqYSRUU4crGiJEXuHNd7tHksx+/C5yNTiSI2OG5f4EnD2ayzIRN1UxKS4Qc7at32XNVtGqV1 u+QYzamo21BcNV4SEVBYbuo1BQxXf40RDsyh6P5n2LGbKie/+T+B/ImluiYywQAAAABJRU5ErkJg gg== In-Reply-To: <2987971e-9d16-0ec7-6474-55dc742afdff@cs.ucla.edu> (Paul Eggert's message of "Sun, 23 Jun 2019 14:00:06 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238077 Archived-At: Paul Eggert writes: > I wrote a simple three-line patch to fix them all, but if > you'd rather do it the hard way and "audit the sources from now to > eternity" to make sure the hard way continues to be done correctly > everywhere in the future, please feel free to do that. Or if you want > to fix just message_to_stderr but not the other occurrences of the > problem, please feel free to do that too. Either of these things would > improve over what is in master now, although they wouldn't be as good > as the three-line fix. I agree with you that the line buffering fix was more elegant, but it's an unnerving change. Just fixing message_to_stderr, on the other hand, wouldn't scare anybody and gets us almost all the way there. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no