From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: Fix eudc-get-attribute-list: please review Date: Wed, 13 Apr 2022 22:02:08 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="920"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 14 04:03:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neopw-000AaN-2M for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Apr 2022 04:03:56 +0200 Original-Received: from localhost ([::1]:46996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neopu-0005i5-LL for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Apr 2022 22:03:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neooH-0004yF-P4 for emacs-devel@gnu.org; Wed, 13 Apr 2022 22:02:13 -0400 Original-Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:46744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1neooF-0005mn-B0 for emacs-devel@gnu.org; Wed, 13 Apr 2022 22:02:13 -0400 Original-Received: by mail-qt1-x831.google.com with SMTP id z15so2653313qtj.13 for ; Wed, 13 Apr 2022 19:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=KAnBbnv609Q/0KeoBwLY19mO4nUnYd8vWDR8PPd63OA=; b=3ZACuM+PSHIRlIap0zVkGOWYp3cJIVtXI/mCAkjmACQxOUY+3jHmTVAc6LFWsMVfwj tYvm0lHD3LtBWFx6n8adnsBbs8ctuu+6q24tRaKIPDpluw0d+njOB/Y2XQGqiXKywQm7 iWgzptR3PFzUwFBIn7wVYD5VL0X/nI4YNW/4pfxZPzcPgrLFreoOSqO/IrhEKbUhQYc+ UDW4qh1dOk9FIvOCJQec5HlO/tRtSN0PvuR0GBpY7l0z9bTm4Hk9jyufpIyokWRE5XIK 2syiS/toMSWmaqTsuE0hF0LbDy516ZVRvJVB0xLPud1oTAkBDGVbO0CVSOpm9rWO1kW7 Tt2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KAnBbnv609Q/0KeoBwLY19mO4nUnYd8vWDR8PPd63OA=; b=rN4SE33tjWckccDtrALMKE2K66NIGJnsWy7fqwXovxYV6cZvo3xEH+53RwNndQUpnE SmDQcG4Y5fGmr738e65IcXc7aSu4XpcoL97o6jcyVrMhe14MS1wv0Pc8OIi3tvUU/4q3 L5vVMuZpzQqm/rX3PHoJzcZ3Ygi/E2kkTv8z1ohWhyI8M10tgo6KcSsMatNDrSlUMHDZ Rx7fgAssmw3eF4ksDGQjpNyZXXflUA1D2Cuw7pHyQOjvnxOVZx9OlnhdWGCgXU+ukzuF AXR5Cg2Yzi1dl8RlUYBbPtklNGs5j65GbzzeecS8jDJXTbSZSqOH9ni9MUW2/zQ8TLdz HG4g== X-Gm-Message-State: AOAM533X2fwIcmGqZ/0oQR16cmyzlyoXEC6mD6AzWhL/V25osiQnR7aT +sTCP94NnzOLZWbHwDpXqvZUOkkXV7UIaA== X-Google-Smtp-Source: ABdhPJy882RW2KonRChmJVjP1miJnsDM1A186nd/gXUhCG5PKZ7mRS+aVHJYr2Me9cxuyEaxLL4hHw== X-Received: by 2002:ac8:7258:0:b0:2f1:d71e:be89 with SMTP id l24-20020ac87258000000b002f1d71ebe89mr279710qtp.48.1649901729396; Wed, 13 Apr 2022 19:02:09 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id b2-20020a37b202000000b0069c7ad47221sm30379qkf.38.2022.04.13.19.02.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 19:02:09 -0700 (PDT) In-Reply-To: (Filipp Gunbin's message of "Wed, 13 Apr 2022 23:14:55 +0300") Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=fitzsim@fitzsim.org; helo=mail-qt1-x831.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288378 Archived-At: Hi Filipp, Filipp Gunbin writes: > Here's the patch which fixes several bugs preventing > eudc-get-attribute-list from working, please review. > > TIA, > Filipp > > > commit 17c59e12adca5386ffe7d107dc6e3fa2dcf8b8d6 > Author: Filipp Gunbin > Date: Wed Apr 13 23:10:35 2022 +0300 > > Fix eudc-get-attribute-list > > * lisp/net/eudc-vars.el (eudc-ldap-no-wildcard-attributes): New > defcustom. > * doc/misc/eudc.texi (LDAP Configuration): Mention it. > * lisp/net/eudcb-ldap.el (eudc-ldap-format-query-as-rfc1558): Use it. > (eudc-ldap-get-field-list): Set scope and sizelimit, instead of > overriding the whole ldap-host-parameters-alist. > * lisp/net/ldap.el (ldap-search-internal): Allow "size limit exceeded" > exit code. Allow empty attribute values. Looks good, and works for me. Please go ahead and push this to the master branch. One question: what does the addition of the question mark to the regexp fix? Thanks, Thomas