From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: emacs-devel@gnu.org
Subject: Re: Fix eudc-get-attribute-list: please review
Date: Wed, 13 Apr 2022 22:02:08 -0400 [thread overview]
Message-ID: <m3a6copgm7.fsf@fitzsim.org> (raw)
In-Reply-To: <m2zgkokaf4.fsf@fastmail.fm> (Filipp Gunbin's message of "Wed, 13 Apr 2022 23:14:55 +0300")
Hi Filipp,
Filipp Gunbin <fgunbin@fastmail.fm> writes:
> Here's the patch which fixes several bugs preventing
> eudc-get-attribute-list from working, please review.
>
> TIA,
> Filipp
>
>
> commit 17c59e12adca5386ffe7d107dc6e3fa2dcf8b8d6
> Author: Filipp Gunbin <fgunbin@fastmail.fm>
> Date: Wed Apr 13 23:10:35 2022 +0300
>
> Fix eudc-get-attribute-list
>
> * lisp/net/eudc-vars.el (eudc-ldap-no-wildcard-attributes): New
> defcustom.
> * doc/misc/eudc.texi (LDAP Configuration): Mention it.
> * lisp/net/eudcb-ldap.el (eudc-ldap-format-query-as-rfc1558): Use it.
> (eudc-ldap-get-field-list): Set scope and sizelimit, instead of
> overriding the whole ldap-host-parameters-alist.
> * lisp/net/ldap.el (ldap-search-internal): Allow "size limit exceeded"
> exit code. Allow empty attribute values.
Looks good, and works for me. Please go ahead and push this to the
master branch. One question: what does the addition of the question
mark to the regexp fix?
Thanks,
Thomas
next prev parent reply other threads:[~2022-04-14 2:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 20:14 Fix eudc-get-attribute-list: please review Filipp Gunbin
2022-04-14 2:02 ` Thomas Fitzsimmons [this message]
2022-04-14 13:57 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3a6copgm7.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).