From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EUDC email addresses via completion-at-point in message-mode Date: Tue, 10 May 2022 17:16:45 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20839"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Filipp Gunbin , emacs-devel@gnu.org To: Alexander Adolf Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 10 23:17:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noXEt-0005AR-Bn for ged-emacs-devel@m.gmane-mx.org; Tue, 10 May 2022 23:17:51 +0200 Original-Received: from localhost ([::1]:49474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noXEs-0002Pt-87 for ged-emacs-devel@m.gmane-mx.org; Tue, 10 May 2022 17:17:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noXDx-0001j4-DX for emacs-devel@gnu.org; Tue, 10 May 2022 17:16:53 -0400 Original-Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]:45010) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1noXDv-0002UV-7H for emacs-devel@gnu.org; Tue, 10 May 2022 17:16:52 -0400 Original-Received: by mail-io1-xd2a.google.com with SMTP id e194so81267iof.11 for ; Tue, 10 May 2022 14:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2i71X4hY/AUa+DOzpYdf+6+MTFrtcuDiVYDPB7Bc2gs=; b=OkBNZOJRcyRGQCbkRcGr2Az4hFgpbPa5C5ia1WQDQ3rnCzXYdXYIZOk6ulNn7CzsSy 59Uug2sas91NtZvUxwvycKT/mOnHietlhPcbWl4XfFXSZU9MYdAgNI3OD1TaMCevjz7e UIv1qi1tdvCE0e/2stmBBXk5MxoRgjKbwICAOHwFbD0Mu41AVdhUZpP2vSXoRgEqm8Eb Ckcu3os+cL31/LEwDfl4RYEiqSae1QKyBVqHh/U+OtBOqK5lRrUHpWuemLsiNhJxKUeV gzRCd5X2bRuQGuZ2UhTCm+MdCT2U9Te5/ykUGKNS0uvwuJ11ocrhswtsDuKFxNfQY0u9 U6Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2i71X4hY/AUa+DOzpYdf+6+MTFrtcuDiVYDPB7Bc2gs=; b=iOyb7pY/ZDUGLl+fEpdQXFa4kg+wOO437n5wKge7EU1REwrJZx9vILmYB3Id02Vc3A dARChLTwJkPcuGzdQHO6lglMHXAHw3gXnQWl0JZFiH0qRa4pwAomaCA1odoWfiUskQ6h Cqf1ID8bgunbQcr7+scaFHiBr/UFmjLyAnnHgG15DgCZFMIszPDV4Le7QNXkemJPE4dt 1wo8oAsMHMm1cwA0kAuN8pjG3RDRtTjvAY8o9a+UHl3zwpE0IglA8bxc9YSC6xY5FOOE GazfFv4Ok4/ZdXMtGmYT3acDGAalkRpcMzsWxCf8FFXzRCd4KO7T26ANs1YSSSHlrfZb tA/g== X-Gm-Message-State: AOAM533DJg4XZi+2T6mTShTYKxGrfrGt5TkepGqacQ5wJVi9GYnXKBBD cNo6sdLWfWW54DZvzA+5PlAb6TMsjoemcw== X-Google-Smtp-Source: ABdhPJxsDBbOvHcN8VhGZ++w9gDfb+eug/UBRUsz947NUXm5rFa9Z8P5gtiULZIMT8Iq+CqjQLkmCg== X-Received: by 2002:a5d:9817:0:b0:65a:f20b:db2c with SMTP id a23-20020a5d9817000000b0065af20bdb2cmr5963229iol.118.1652217407732; Tue, 10 May 2022 14:16:47 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id e11-20020a921e0b000000b002cde6e352bfsm138998ile.9.2022.05.10.14.16.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 May 2022 14:16:46 -0700 (PDT) In-Reply-To: (Thomas Fitzsimmons's message of "Thu, 05 May 2022 12:57:28 -0400") Received-SPF: pass client-ip=2607:f8b0:4864:20::d2a; envelope-from=fitzsim@fitzsim.org; helo=mail-io1-xd2a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289603 Archived-At: Hi Alexander, Thomas Fitzsimmons writes: [...] > In any case, I think your patch is an improvement to the default > message.el behaviour, and I don't necessarily want to hold it up waiting > for built-in CAPF front-end redesigns. Let's give it another day and if > we haven't figured out this design/optimization issue by then, I'll push > what you've provided so far, as a work-in-progress. I pushed your patch. I made some cosmetic changes to the log message, making the first line shorter and quoting function names correctly. I also fixed the following texinfo warnings: eudc.texi:892: @pxref reference to nonexistent node `Inline Query Expansion Using a Key Binding' eudc.texi:897: @pxref reference to nonexistent node `Message' Thanks, Thomas