From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [GNU ELPA] New package: url-http-oauth Date: Mon, 08 May 2023 11:27:38 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35550"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 08 17:29:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pw2nm-0008yX-QE for ged-emacs-devel@m.gmane-mx.org; Mon, 08 May 2023 17:29:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pw2mA-0005aU-Ua; Mon, 08 May 2023 11:27:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw2m8-0005O1-HF for emacs-devel@gnu.org; Mon, 08 May 2023 11:27:44 -0400 Original-Received: from mail.fitzsim.org ([69.165.165.189]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw2m6-0004dY-DT for emacs-devel@gnu.org; Mon, 08 May 2023 11:27:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fitzsim.org ; s=20220430; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GWEJjQ13c34usus1bIKYs7LiIU0ADy+qoHHU4o1UbNA=; b=c+c/n3aEb594TsFT6h5ud8PH+J 21d18Vq1OnHzkXtKoa6XHiVuG4lNyBPMm9rcNB72FMb/DdwnSeS0BRvOnPGPcWbCAeSOSu87L1sHW 91Gjqdnytfaep2+xmw02tNcS43YVUPIqdI4CkZxXaB2VVqeaRD7TJzpDOdMedFj8Ga/Zo+sJXyXuG aHWXbeGFiwmY2x0n1G0e2P6enORdclN2zJ4G3F4Y066l//p9y/VfnDyEWPL87YDIqAhfPymBMkztl VgxXl8n7ztoodzHnhG0gjvEjmEdp3ab3e3h5JdTmfMerFbLRxXfXsIxPbkYzvA5CzVR58HHG1nnK9 orEraMSw==; Original-Received: from [192.168.1.1] (helo=localhost.localdomain) by mail.fitzsim.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pw2m3-0007eP-H5; Mon, 08 May 2023 11:27:39 -0400 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 8 May 2023 08:50:06 +0100") Received-SPF: pass client-ip=69.165.165.189; envelope-from=fitzsim@fitzsim.org; helo=mail.fitzsim.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305983 Archived-At: Hi Jo=C3=A3o, Jo=C3=A3o T=C3=A1vora writes: > I think packages such as this one are very welcome, and I appreciate the > UI-agnostic architecture you describe. Thanks. > Url.el itself, last i looked, seemed a bit outdated and hard to work > with. I find it OK to work with. It's primarily elisp, vs some other proposals I've seen, so I can step through most of it with edebug. There's one FIXME in url-http-oauth currently that may represent a url.el oddity (or may represent me doing something wrong): ;; FIXME: if anything goes wrong during the authentication steps, ;; `url-http-end-of-document-sentinel' calls back into ;; `url-oauth-auth' somehow. Maybe `url-http-no-retry' can help here? I'm sure other client libraries would have oddities too though. Are there bugs filed for the specific ways in which url.el may be outdated or hard to work with? Maybe someone could maintain a collection of links to those bug reports, to see how contenders measure up? Of course, that list wouldn't represent the upsides of url.el, such as the elisp purity I mentioned. > Are there other http client libraries for Emacs? Today url.el works for me, so I don't have plans to change; I'll probably just follow what makes it into Emacs core. > Could they also take advantage of your new library? If the new library implemented url.el's APIs, then sure. I would accept well-defined/minimal compatibility patches for other client libraries too, of course. Thomas