Build Failure with Latest CVS sources

Build Failure with Latest CVS sources

[Vin Shelton]

I'm getting the following error while building from emacs from the
latest CVS sources:

gcc -c -I/u/shelton2/software/SunOS-5.8/include -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/u/shelton2/software/src/emacs-2003-07-15/src -I/usr/openwin/include -I/usr/dt/include -g /u/shelton2/software/src/emacs-2003-07-15/src/xfns.c
/u/shelton2/software/src/emacs-2003-07-15/src/xfns.c:7568:24: libpng/png.h: No such file or directory
/u/shelton2/software/src/emacs-2003-07-15/src/xfns.c:7647: error: parse error before "png_struct"

Here is the configure command I used:
    /u/shelton2/software/src/emacs-2003-07-15/configure
    --prefix=/u/shelton2/software/SunOS-5.8/emacs-2003-07-15
    --datadir=/u/shelton2/software/share --disable-nls
    --without-toolkit-scroll-bars

This is on a Solaris 5.8 box.  I could build with this configuration
up until July 11.  Since that time the line to include png.h in xfns.c
has changed from:

#include <png.h>

to:

#include <libpng/png.h>

In fact, png.h lives in /u/shelton2/software/SunOS-5.8/include, there
is no libpng subdirectory.

HTH,
  Vin

Cannot Generate loaddefs.el on Solaris

[Vin Shelton]

/bin/sh on Solaris has stricter syntax wrt the 'test' command than
bash does.  The !  (negation) operator cannot appear before the 'test'
command.  Without the attached patch, I cannot build the latest CVS
sources on Solaris (either 5.5.1 or 5.8) because loaddefs.el does not
get created properly.

Index: lisp/ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.5400
diff -u -U0 -r1.5400 ChangeLog
--- lisp/ChangeLog	22 Sep 2003 12:37:00 -0000	1.5400
+++ lisp/ChangeLog	22 Sep 2003 13:26:40 -0000
@@ -0,0 +1,4 @@
+2003-09-22  Vin Shelton  <acs@xemacs.org>
+
+	* Makefile.in: On Solaris sh, ! must be inside args to test.
+
Index: lisp/Makefile.in
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/Makefile.in,v
retrieving revision 1.45
diff -u -u -r1.45 Makefile.in
--- lisp/Makefile.in	15 Sep 2003 05:36:56 -0000	1.45
+++ lisp/Makefile.in	22 Sep 2003 13:26:57 -0000
@@ -292,7 +292,7 @@
 	if test -x $(EMACS); then				\
 	  $(MAKE) $(MFLAGS) autoloads;				\
 	else							\
-	  if ! test -r $(lisp)/loaddefs.el; then		\
+	  if test ! -r $(lisp)/loaddefs.el; then		\
 	    cp $(lisp)/loaddefs-boot.el $(lisp)/loaddefs.el;	\
 	  fi							\
 	fi

HTH,
  Vin Shelton

-- 
In a minute there is time
For decisions and revisions which a minute will reverse.         T.S. Eliot
[URL: http://www.cs.amherst.edu/~ccm/prufrock.html]

Re: Cannot Generate loaddefs.el on Solaris

[Miles Bader]

On Mon, Sep 22, 2003 at 11:02:06AM -0400, Vin Shelton wrote:
> /bin/sh on Solaris has stricter syntax wrt the 'test' command than
> bash does.  The !  (negation) operator cannot appear before the 'test'
> command.
> -	  if ! test -r $(lisp)/loaddefs.el; then		\
> +	  if test ! -r $(lisp)/loaddefs.el; then		\

Note that the ! in the former case is actually a (posix) shell construct, not
a test operator.

I'm not entirely comfortable with the ! test operator either, but a bit of
googling suggests that it's OK even on ancient systems, as long as the
following expression is not `weird.'

(I always test my scripts for portability on sunos because sun seems to have
last updated some of their utilities in about 1985!)

Thanks,

-Miles
-- 
"Though they may have different meanings, the cries of 'Yeeeee-haw!' and
 'Allahu akbar!' are, in spirit, not actually all that different."

Re: Cannot Generate loaddefs.el on Solaris

[Vin Shelton]

Miles Bader <miles@gnu.org> writes:
> On Mon, Sep 22, 2003 at 11:02:06AM -0400, Vin Shelton wrote:
>> /bin/sh on Solaris has stricter syntax wrt the 'test' command than
>> bash does.  The !  (negation) operator cannot appear before the 'test'
>> command.
>> -	  if ! test -r $(lisp)/loaddefs.el; then		\
>> +	  if test ! -r $(lisp)/loaddefs.el; then		\
>
> Note that the ! in the former case is actually a (posix) shell construct, not
> a test operator.
>
> I'm not entirely comfortable with the ! test operator either, but a bit of
> googling suggests that it's OK even on ancient systems, as long as the
> following expression is not `weird.'
>
> (I always test my scripts for portability on sunos because sun seems to have
> last updated some of their utilities in about 1985!)

Miles,

Thanks for the reply.  I may have given you the wrong impression -
namely that I was writing hypothetically.  The actual situation is
that the version in CVS does not work on the Solaris systems at work:
loaddefs.el does not get created, and therefore emacs dumping does not
work.  (IIRC, the message is something like: "!: command not found".)
When I apply the patch, loaddefs.el _does_ get created and I can
successfully dump emacs.  (BTW, I think the build started failing for
me on or about September 12.)

The systems in question are pretty much stock Solaris 5.8 and 5.5.1
systems.

I'm pretty sure that /bin/sh on these Sparc Solaris systems is not
POSIX-compliant.

  - Vin

Re: Cannot Generate loaddefs.el on Solaris

[Miles Bader]

Vin Shelton <acs@xemacs.org> writes:
> Thanks for the reply.  I may have given you the wrong impression -
> namely that I was writing hypothetically.  The actual situation is
> that the version in CVS does not work on the Solaris systems at work:

Don't worry, I have no trouble at all believing that solaris is broken
in this regard (I use sun systems at work, and seem to get bitten in the
ass just about every day by this kind of crap).

In fact I already made the change (it's in my arch archive though, and
won't propagate to CVS until tomorrow).

Thanks,

-Miles
-- 
[|nurgle|]  ddt- demonic? so quake will have an evil kinda setting? one that 
            will  make every christian in the world foamm at the mouth? 
[iddt]      nurg, that's the goal