From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Klaus Straubinger Newsgroups: gmane.emacs.devel Subject: Fix for release-critical bug in url-http.el Date: Mon, 3 Jan 2005 16:16:04 +0100 (CET) Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1104765685 21810 80.91.229.6 (3 Jan 2005 15:21:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 Jan 2005 15:21:25 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 03 16:21:16 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ClU1D-00056M-00 for ; Mon, 03 Jan 2005 16:21:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1ClUCN-0004j7-Iq for ged-emacs-devel@m.gmane.org; Mon, 03 Jan 2005 10:32:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1ClUBs-0004SW-U8 for emacs-devel@gnu.org; Mon, 03 Jan 2005 10:32:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1ClUBr-0004R5-2e for emacs-devel@gnu.org; Mon, 03 Jan 2005 10:32:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1ClUBq-0004QA-Sz for emacs-devel@gnu.org; Mon, 03 Jan 2005 10:32:14 -0500 Original-Received: from [155.56.68.170] (helo=smtpde02.sap-ag.de) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ClTwG-0005GW-UK for emacs-devel@gnu.org; Mon, 03 Jan 2005 10:16:09 -0500 Original-Received: from sap-ag.de (smtpde02) by smtpde02.sap-ag.de (out) with ESMTP id QAA11474 for ; Mon, 3 Jan 2005 16:16:03 +0100 (MEZ) Original-To: emacs-devel@gnu.org X-Mailer: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 X-SAP: out X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31732 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31732 In admin/FOR-RELEASE a bug is described in url-http.el that is said to come from url-http-parse-headers. However, I tracked this bug down to a bad "(kill-buffer (current-buffer))" in the function url-http-handle-authentication. The following fix cured the problem completely for me, so I would suggest to implement it instead of the suggested fix from the bug's original message which could not work as far as I understand. --- url-http.el.orig 2004-12-01 14:30:34.000000000 +0100 +++ url-http.el 2005-01-03 16:03:43.710185096 +0100 @@ -322,8 +322,8 @@ (let ((url-request-method url-http-method) (url-request-data url-http-data) (url-request-extra-headers url-http-extra-headers)) - (url-retrieve url url-callback-function url-callback-arguments)))) - (kill-buffer (current-buffer))))) + (url-retrieve url url-callback-function + url-callback-arguments))))))) (defun url-http-parse-response () "Parse just the response code." --- ChangeLog.orig 2004-12-14 14:25:16.000000000 +0100 +++ ChangeLog 2005-01-03 16:05:53.785410656 +0100 @@ -1,3 +1,8 @@ +2005-01-03 Klaus Straubinger + + * url-http.el (url-http-handle-authentication): Don't kill the + current buffer. + 2004-12-11 Stefan Monnier * url-handlers.el: Don't `require' everything eagerly. Regards Klaus Straubinger