* Fix for release-critical bug in url-http.el
@ 2005-01-03 15:16 Klaus Straubinger
2005-01-03 16:57 ` Thien-Thi Nguyen
2005-01-04 3:38 ` Richard Stallman
0 siblings, 2 replies; 4+ messages in thread
From: Klaus Straubinger @ 2005-01-03 15:16 UTC (permalink / raw)
In admin/FOR-RELEASE a bug is described in url-http.el that is said to
come from url-http-parse-headers. However, I tracked this bug down to
a bad "(kill-buffer (current-buffer))" in the function
url-http-handle-authentication. The following fix cured the problem
completely for me, so I would suggest to implement it instead of the
suggested fix from the bug's original message which could not work
as far as I understand.
--- url-http.el.orig 2004-12-01 14:30:34.000000000 +0100
+++ url-http.el 2005-01-03 16:03:43.710185096 +0100
@@ -322,8 +322,8 @@
(let ((url-request-method url-http-method)
(url-request-data url-http-data)
(url-request-extra-headers url-http-extra-headers))
- (url-retrieve url url-callback-function url-callback-arguments))))
- (kill-buffer (current-buffer)))))
+ (url-retrieve url url-callback-function
+ url-callback-arguments)))))))
(defun url-http-parse-response ()
"Parse just the response code."
--- ChangeLog.orig 2004-12-14 14:25:16.000000000 +0100
+++ ChangeLog 2005-01-03 16:05:53.785410656 +0100
@@ -1,3 +1,8 @@
+2005-01-03 Klaus Straubinger <ksnetz@arcor.de>
+
+ * url-http.el (url-http-handle-authentication): Don't kill the
+ current buffer.
+
2004-12-11 Stefan Monnier <monnier@iro.umontreal.ca>
* url-handlers.el: Don't `require' everything eagerly.
Regards
Klaus Straubinger
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix for release-critical bug in url-http.el
2005-01-03 15:16 Fix for release-critical bug in url-http.el Klaus Straubinger
@ 2005-01-03 16:57 ` Thien-Thi Nguyen
2005-01-03 20:31 ` Stefan Monnier
2005-01-04 3:38 ` Richard Stallman
1 sibling, 1 reply; 4+ messages in thread
From: Thien-Thi Nguyen @ 2005-01-03 16:57 UTC (permalink / raw)
Cc: emacs-devel
Date: Mon, 3 Jan 2005 16:16:04 +0100 (CET)
From: Klaus Straubinger <KSNetz@Arcor.DE>
The following fix cured the problem completely for me [...]
thanks, installed.
thi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix for release-critical bug in url-http.el
2005-01-03 16:57 ` Thien-Thi Nguyen
@ 2005-01-03 20:31 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2005-01-03 20:31 UTC (permalink / raw)
Cc: KSNetz, emacs-devel
> The following fix cured the problem completely for me [...]
> thanks, installed.
Please remove the entry in FOR-RELEASE as well, if that fixes the problem.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix for release-critical bug in url-http.el
2005-01-03 15:16 Fix for release-critical bug in url-http.el Klaus Straubinger
2005-01-03 16:57 ` Thien-Thi Nguyen
@ 2005-01-04 3:38 ` Richard Stallman
1 sibling, 0 replies; 4+ messages in thread
From: Richard Stallman @ 2005-01-04 3:38 UTC (permalink / raw)
Cc: emacs-devel
Thanks for debugging this.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-01-04 3:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-03 15:16 Fix for release-critical bug in url-http.el Klaus Straubinger
2005-01-03 16:57 ` Thien-Thi Nguyen
2005-01-03 20:31 ` Stefan Monnier
2005-01-04 3:38 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).