From: Klaus Straubinger <KSNetz@Arcor.DE>
Subject: Fix for release-critical bug in url-http.el
Date: Mon, 3 Jan 2005 16:16:04 +0100 (CET) [thread overview]
Message-ID: <m38y7aee6j.fsf@P131831.SAP.Corp> (raw)
In admin/FOR-RELEASE a bug is described in url-http.el that is said to
come from url-http-parse-headers. However, I tracked this bug down to
a bad "(kill-buffer (current-buffer))" in the function
url-http-handle-authentication. The following fix cured the problem
completely for me, so I would suggest to implement it instead of the
suggested fix from the bug's original message which could not work
as far as I understand.
--- url-http.el.orig 2004-12-01 14:30:34.000000000 +0100
+++ url-http.el 2005-01-03 16:03:43.710185096 +0100
@@ -322,8 +322,8 @@
(let ((url-request-method url-http-method)
(url-request-data url-http-data)
(url-request-extra-headers url-http-extra-headers))
- (url-retrieve url url-callback-function url-callback-arguments))))
- (kill-buffer (current-buffer)))))
+ (url-retrieve url url-callback-function
+ url-callback-arguments)))))))
(defun url-http-parse-response ()
"Parse just the response code."
--- ChangeLog.orig 2004-12-14 14:25:16.000000000 +0100
+++ ChangeLog 2005-01-03 16:05:53.785410656 +0100
@@ -1,3 +1,8 @@
+2005-01-03 Klaus Straubinger <ksnetz@arcor.de>
+
+ * url-http.el (url-http-handle-authentication): Don't kill the
+ current buffer.
+
2004-12-11 Stefan Monnier <monnier@iro.umontreal.ca>
* url-handlers.el: Don't `require' everything eagerly.
Regards
Klaus Straubinger
next reply other threads:[~2005-01-03 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 15:16 Klaus Straubinger [this message]
2005-01-03 16:57 ` Fix for release-critical bug in url-http.el Thien-Thi Nguyen
2005-01-03 20:31 ` Stefan Monnier
2005-01-04 3:38 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38y7aee6j.fsf@P131831.SAP.Corp \
--to=ksnetz@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).