unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: incomplete header-line with 3d boxes and prop fonts
Date: Mon, 24 Apr 2006 02:25:04 +0200	[thread overview]
Message-ID: <m38xpvq0pr.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <jwvslpcoio8.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 20 Mar 2006 17:35:05 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Try the following command:
>
>    src/emacs -Q --eval '(set-face-attribute (quote header-line) nil :family "helv")' ~/tmp/foo.ses
>
> If you don't have a foo.ses file, you'll get an empty spreadsheet.
> Now hit M-o a few times to add some columns.
>
> Now two things:
>
> 1 - as already reported, the right hand side of the 3d boxes in the
>     header-line are missing.
>
> 2 - the last few pixels of the header-line are missing.  Most likely you
>     will not have noticed it yet because it's ben correctly drawn earlier
>     and hasn't been overdrawn yet.  But try C-l to see what's really
>     going on: for each 3d box in the header line a few pixels are lost at
>     the right edge of the header-line.
>
> The same thing happens with the mode-line (except that 3d boxes in the
> mode-line are harder to come by, except for mouse-face highlights and those
> don't seem to suffer from that problem).

I installed a trivial fix for the missing right 3D border -- it seems
to only hit a boxed stretch glyph.


But the result (in ses-mode) isn't pleasing ... the cell contents gets
more and more misaligned with the header line.  I tracked this to a
problem with the calculation of the size of a :box'ed stretch glyph.

I'm not sure how the fix I've installed for this may break other code
using box'ed stretch glyphs.  

The fix is to simply assume that the specified :width, :height or :align-to
includes the face box width/height (which seems to be TRT, as the code
using this shouldn't have to take special actions for boxed faces (which
are often used in header (and mode) lines.

Please report any problems -- if any, there  probably is a trivial
fix at the Lisp level !!

--
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2006-04-24  0:25 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-20 22:35 incomplete header-line with 3d boxes and prop fonts Stefan Monnier
2006-04-24  0:25 ` Kim F. Storm [this message]
2006-04-24  6:58   ` Stefan Monnier
2006-04-24 11:51   ` Richard Stallman
2006-04-24 12:11     ` Kim F. Storm
2006-04-25  3:16       ` Jonathan Yavner
2006-04-25 22:04         ` Richard Stallman
2006-04-25 12:38       ` Sascha Wilde
2006-04-25 14:47         ` Kim F. Storm
2006-04-25 15:11           ` Sascha Wilde
2006-04-27 22:53             ` Kim F. Storm
2006-04-28 11:34               ` Default face problem [was: Re: incomplete header-line with 3d boxes and prop fonts] Kim F. Storm
2006-05-01  2:41                 ` Kenichi Handa
2006-05-01  3:14                   ` Default face problem Stefan Monnier
2006-05-01  4:32                     ` Kenichi Handa
2006-05-01 12:34                       ` Stefan Monnier
2006-05-01 12:51                         ` Kenichi Handa
2006-05-01 13:58                           ` Stefan Monnier
2006-05-02  0:42                             ` Kenichi Handa
2006-05-01  8:25                   ` Kim F. Storm
2006-05-01 12:35                     ` Stefan Monnier
2006-05-01 12:49                       ` Kim F. Storm
2006-05-08  5:51                     ` Kenichi Handa
2006-05-08  8:47                       ` Kim F. Storm
2006-05-08 11:50                         ` Kenichi Handa
2006-05-08 12:19                           ` Kim F. Storm
2006-05-10  4:17                             ` Kenichi Handa
2006-05-10 12:21                               ` Kim F. Storm
2006-05-10 12:41                                 ` Kenichi Handa
2006-05-10 17:45                                   ` Eli Zaretskii
2006-05-11  0:36                                     ` Kenichi Handa
2006-05-11  3:40                                       ` Eli Zaretskii
2006-05-11  4:35                                         ` Kenichi Handa
2006-05-13 13:04                                           ` Eli Zaretskii
2006-05-15  1:41                                             ` Kenichi Handa
2006-05-15  3:33                                               ` Eli Zaretskii
2006-05-15  4:47                                                 ` Kenichi Handa
2006-05-10 17:45                               ` Eli Zaretskii
2006-04-24 13:02     ` incomplete header-line with 3d boxes and prop fonts Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38xpvq0pr.fsf@kfs-l.imdomain.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).