From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: arc-mode Date: Sat, 18 May 2019 08:00:38 +0200 Message-ID: References: <83d0khb888.fsf@gnu.org> <83k1eo9uew.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="111168"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 08:02:31 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRsQQ-000Sie-So for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 08:02:31 +0200 Original-Received: from localhost ([127.0.0.1]:58136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRsQP-0002ou-Fc for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 02:02:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRsQF-0002oh-O6 for emacs-devel@gnu.org; Sat, 18 May 2019 02:02:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRsOg-0003ZV-GJ for emacs-devel@gnu.org; Sat, 18 May 2019 02:00:43 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:47182) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRsOg-0003ZA-9s; Sat, 18 May 2019 02:00:42 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hRsOc-000528-Kc; Sat, 18 May 2019 08:00:40 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAMFBMVEXV0dDj4eH+/f38+/ug l5aPh4Xx8O/Burl6cXCvqKf////+//75+fk7NTT39vb19PQ+LG1hAAAB6UlEQVQ4jWPIWoUVrGPA KSGFVXw1LolVa3BJkKODC5fl2CVw6sBtOU479oEkFq/6j13HulVi2CXWrJLBkFgPkliklYNdYvWr ZByuOvUZu8Qiq3zsRq3XysMusXjXt1WHT2GRWKP1b71AFroEMKwEs54llGKT2Kb1sWAqKDCVz9vs QpZYb/WinuEXkHdOIC3JCuZcoMTiLE1hkIPVZoZMl39shZBYnbUcbIJ4ZGiImw2yxK8FIPYaltYb HS48xgg7Vv0yBLHtZly9e8Nz4iOEjlVZC54BSfPYuzc6pnrK7UJI/FpQCOSlgCRap9RoISRemacB 3cbacffu3dbIaUgSh5+nWa1aU9px9wZQIsAKyShzsVer9F17gTquugZkIRm1Us5q1TJXoPjdG6EF p5EklievWr0tBCh89+aUcCSJU8vlVq1SnwqyvIUlMhnJDgNg+jnuEtJ7t7cj3F0Oyah0PqD/XKdE 9N696jKTD8nn6WKrFj9wdXGN6OiInMkNDjioDrZVqxIqS6Z2XG1tqWRCSPwSYFy16jtIoqN1ejk4 vS6G6EgApupn6SURER2h7tMREuusQJYvPug5NaIjZHrlabjE4lWJoDSqI1gS4VDOCIlBiFGLwAG6 yuqYWBYslSzGVcgsZiiXxi4BAID6r0yppUYBAAAAAElFTkSuQmCC In-Reply-To: <83k1eo9uew.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 May 2019 08:57:27 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236699 Archived-At: Eli Zaretskii writes: > Sorry, that's not what I meant. (I guess I've misunderstood what you > were asking about, and thus my "juggling" was misinterpreted.) I > meant to do this instead: > > (defun insert-unibyte (&rest args) > "Like insert but don't make unibyte string and eight-bit char multibyte." > (dolist (elt args) > (if (integerp elt) > (insert (if (< elt 128) elt (decode-char 'eight-bit elt))) > (insert elt)))) > > IOW, just lose the string-to-multibyte part, as I don't think it's > needed nowadays, since 'insert' already does the equivalent of > string-to-multibyte when needed. The warning we want to get rid off > is about string-to-multibyte, not about decode-char, right? Ah, right, yes. But that's unfortunately the part I'm not able to test since the commands that use that path don't actually work... But I think you're right -- the two functions that insert a string insert only encoded strings (with some binary stuff afterwards), so I think that change should be safe. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no