From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: cedet Date: Thu, 13 Jun 2019 03:38:49 +0200 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="257055"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 13 03:52:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbEuI-0014fF-Ja for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 03:52:02 +0200 Original-Received: from localhost ([::1]:36494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbEuG-0006mt-Om for ged-emacs-devel@m.gmane.org; Wed, 12 Jun 2019 21:52:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37919) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbEtH-0006jd-TR for emacs-devel@gnu.org; Wed, 12 Jun 2019 21:51:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbEhc-0001OD-4u for emacs-devel@gnu.org; Wed, 12 Jun 2019 21:38:57 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:43208) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbEhb-0001N0-UR for emacs-devel@gnu.org; Wed, 12 Jun 2019 21:38:56 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbEhV-0003JM-Di for emacs-devel@gnu.org; Thu, 13 Jun 2019 03:38:53 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAMFBMVEUDAAbRxcaonpn9/fbt 6+P29e+bR2vAtr22q6ySi4vl4dnc1dAPCBf////+//4EAQvADDniAAACRklEQVQ4jZ3U32vTQAAH 8PwHo7DZqfRhgbWJzhd9kcoeOlodKy3sQQYbHVjkYAOF/nDJLBNS1Mb1LQ/tDp/GKsWWCsPGaovi ayFQylqqHRdQVnwYgf0Bg3qX1BLcvegXLpfc537kkhCGoeSMOZuwaqtYJ8OJIQlz674Zv5kSSbmB 85VB9LSYSKeDUD+whEhth7zC8fDt6xzP8wpvBzbvYcWP1zjWczn+yg70JfR/Ab0cosOnJheiQWcD sg9p0APQHTUo0N7j3cBFga4SB+AGBY4hAODRRfClc4A2ou8GJDs26EbI8btiQgiDV8XXJxU0+Ezg Z5q0R8k+DlO462A9cBoyl2YJbBKozVTwrg68vYo5YgPC0VQO1R9BvXeTFnyw4PFRi/HVM09Qr5K0 YAFqEN/vJgb0Qy6VF6vZe1PzGO6yc00MDwi0hRlRlGVBekGmis5pkFOuY3h24thtlPyNUlmK6MYl wDebHJzFAFQxUWiHq8eBzPpqegvw0LkFdzCk41zScbOy+00Vxe284yWfc3UmDQx7kpwVFsPPfxVk KTWrB3ngwmthuJMsPmV9X662VamQDBrotnveAhSrJeprB/VTVXCEVg2kh9EIjOVEYKnaWHufitje I3nsy9JhLOOUhKwdNAxdSRQ8shBLoL8AFeXB/pugrf9oKrSS7QvOqXGjMYaFfKfgXUEXR3TV/SvF aRpM8xAqlDXQkd8fqFFG6OZnQAFK/gM0BpKwVmQrgiCIGmP+UYYaLi1czrU/GcE42vB82CL8G+Pp Gv0cpT9yAAAAAElFTkSuQmCC In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 13 Jun 2019 02:18:55 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237476 Archived-At: Lars Ingebrigtsen writes: > 22% of the remaining byte-compilation warnings (if we ignore CEDET; I > swoon every time I have a peek at it) are from calendar: But if we don't ignore cedet... what's up with all those warnings anyway? To take one of the 150 or so examples: cedet/ede/config.el:388:5:Warning: Unknown slot `:c-preprocessor-table' That's from: (setq filemap (append filemap (oref config :c-preprocessor-table))) which results in this compiler macro from eieio-oref: (pcase slot ((and (or `',name (and name (pred keywordp))) (guard (not (memq name eieio--known-slot-names)))) (macroexp--warn-and-return (format-message "Unknown slot `%S'" name) exp 'compile-only)) So... It's saying that the slot name is not in that internal variable? But it's populated by that defclass earlier in the file? Yes: eieio--known-slot-names => (c-preprocessor-files c-preprocessor-table c-include-path tag-info length location summary message position buffer column line file search-function create-function data port user host source type) Oh! Those are without colons? Is that the entire issue here, that the check is strict about colons/not colons and the rest of cedet doesn't care? (I've never used any part of cedet.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no