From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: cedet Date: Thu, 13 Jun 2019 18:23:58 +0200 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="13400"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 13 19:49:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbTrF-0003NF-HY for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 19:49:54 +0200 Original-Received: from localhost ([::1]:42850 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbTrE-0004Nh-2L for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 13:49:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50531) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbSeH-0004Ao-Pp for emacs-devel@gnu.org; Thu, 13 Jun 2019 12:32:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbSWC-0008SY-Vm for emacs-devel@gnu.org; Thu, 13 Jun 2019 12:24:06 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:55146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbSWC-0008J1-JT for emacs-devel@gnu.org; Thu, 13 Jun 2019 12:24:04 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbSW6-0001jQ-W7 for emacs-devel@gnu.org; Thu, 13 Jun 2019 18:24:02 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAMFBMVEUAAAD08DYxLhJ3dD+m nkyyqVFGVlDT03AaGReWiVhfaUa9tm0CAgFaYFTCw3Q7RSO9ju1BAAACFklEQVQ4jb2UP2jUUBzH jxtKh5PykIDzm4ooAX8JeK3l0LwMR0U8uUAn3YKD4CIEOQklLlEKHVpPHlIHs3VxKFqO0Ic4dSgo CEKR29RwHjwk2bLEX8rlcnc6KBR/4+/zvt/f7/f+VSqnFLXTMvrbeoeef3T0h7ynUt+jG+9m85Sq 1PMo3ZhdH8dZvOhTSqcl7+Msy2Lfz2YktU0E6Ss/V3gXJkAV1++m+iWfJoa+NmG2iQAC3XW/tRSy tV46oVESQD1yHrQIaV2ZckIAwv2KgJReH9Q0WwKoi2H7KgJlDFQUAMDxjTdGDsjPAuSlAVbAtAwz BzeL2jhDAiufDMbYieJRAc6nu7DTr2OenSjOjZvCwjwMRRhy/ow3t2+NwAKmewjuPEWJZZ2FayNw hvfEIADjchU0s0UMNgZSyteZBkspaBYhzCzAnJQ/VATQyIHFSAGqYi9TU42xRqBZSpuRtaLdHU/N Ar3NGolmKoyR68Xki2qWgn47bASmpVg8+lhcUY+mASxH7lYOOl17vQCHKk7y0nH36qthx3lrj3d3 Pq1zHkbOgO87bvT9bnmCCQ+bInIe9vbdUBzcK8/8CRehjJzO4Hmnf/y5PPPKwhCHdxxXLg+7dumE 8UUKBFL2+3lPEzGHmy4RdO1pQaXymHMRSWnbuWDyBdaS5qp0D2y7vLqjaWoXX4ipfBnz6v3fns1/ iNq/fB6/APY/9TvzIBR9AAAAAElFTkSuQmCC In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 13 Jun 2019 17:10:14 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237529 Archived-At: Lars Ingebrigtsen writes: > (oref context :buffer) > => # > > (oref context buffer) > => # Oh! ;; Accessing a slot via its :initarg is accepted by EIEIO ;; (but not CLOS) but is a bad idea (for one: it's slower). So it does seem like the right fix is just to go CLOS-style on all the oref/osets instead of :eieio... I tried it, and everything compiles (with 111 fewer warnings :-)), so perhaps I should just push it? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no