From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Suspicious code in search.c Date: Thu, 20 Oct 2005 16:52:26 +0200 Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1129820354 1927 80.91.229.2 (20 Oct 2005 14:59:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 Oct 2005 14:59:14 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 20 16:59:04 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ESbn9-00077b-9L for ged-emacs-devel@m.gmane.org; Thu, 20 Oct 2005 16:53:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESbn8-00074t-Of for ged-emacs-devel@m.gmane.org; Thu, 20 Oct 2005 10:53:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ESbn0-00073z-Ca for emacs-devel@gnu.org; Thu, 20 Oct 2005 10:53:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ESbmy-00073j-Q7 for emacs-devel@gnu.org; Thu, 20 Oct 2005 10:53:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESbmy-00073g-Kd for emacs-devel@gnu.org; Thu, 20 Oct 2005 10:53:04 -0400 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ESbmy-0004uG-Tb for emacs-devel@gnu.org; Thu, 20 Oct 2005 10:53:05 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepb.post.tele.dk (Postfix) with SMTP id D2B495EE046 for ; Thu, 20 Oct 2005 16:53:03 +0200 (CEST) Original-To: emacs-devel@gnu.org User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44430 Archived-At: See search.c line 1711-1712: if (ASCII_BYTE_P (*ptr) || ! multibyte) ch = *ptr; --> else if (charset_base --> && (pat_end - ptr) == 1 || CHAR_HEAD_P (ptr[1])) { unsigned char *charstart = ptr - 1; Based on the indentation, I would assume the following interpretation is intended: else if (charset_base && ((pat_end - ptr) == 1 || CHAR_HEAD_P (ptr[1]))) ^ ^ Can somebody who knows this code better than I take a look (and perhaps reformat the code if the current code is ok). -- Kim F. Storm http://www.cua.dk