From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Benjamin Riefenstahl Newsgroups: gmane.emacs.devel Subject: Re: bootstrap problem with union Lisp_Object Date: Tue, 06 Dec 2005 22:05:12 +0100 Message-ID: References: <55DA5764-DDB6-4858-9CE2-065857CDC863@gnu.org> <3AFF0594-F842-4079-9A3B-D1CF7358A281@raeburn.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1133904051 24517 80.91.229.2 (6 Dec 2005 21:20:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 6 Dec 2005 21:20:51 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 06 22:20:49 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EjkBN-0003pD-14 for ged-emacs-devel@m.gmane.org; Tue, 06 Dec 2005 22:17:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EjkBZ-0001DG-42 for ged-emacs-devel@m.gmane.org; Tue, 06 Dec 2005 16:17:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ejk1M-0004sV-9r for emacs-devel@gnu.org; Tue, 06 Dec 2005 16:06:44 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ejk1K-0004rT-3U for emacs-devel@gnu.org; Tue, 06 Dec 2005 16:06:43 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ejk1J-0004rO-VC for emacs-devel@gnu.org; Tue, 06 Dec 2005 16:06:42 -0500 Original-Received: from [193.99.153.30] (helo=seneca.benny.turtle-trading.net) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1Ejk22-0001hs-Pb for emacs-devel@gnu.org; Tue, 06 Dec 2005 16:07:27 -0500 Original-Received: from seneca.benny.turtle-trading.net.turtle-trading.net (seneca.benny.turtle-trading.net [127.0.0.1]) (authenticated bits=0) by seneca.benny.turtle-trading.net (8.12.8/8.12.8) with ESMTP id jB6L5DLn000461; Tue, 6 Dec 2005 22:05:17 +0100 Original-To: Ken Raeburn In-Reply-To: <3AFF0594-F842-4079-9A3B-D1CF7358A281@raeburn.org> (Ken Raeburn's message of "Tue, 6 Dec 2005 02:50:08 -0500") User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47071 Archived-At: Hi Ken, Ken Raeburn writes: > I'm unsure about this bit in w32select.c: > ok = !NILP(render (make_number (current_clipboard_type))); > Someone familiar with the Windows code should please decide whether > calling render twice is a bad thing, and if so, assign the value to > a temporary before calling NILP. Calling render twice shouldn't cause bugs, but the problem is that it's a pretty expensive call. I can make the changes, but I really wonder if a basic and often-used functionality like NILP should be so dangerous. benny