* vc-git bug in vc-dir
@ 2009-12-01 19:54 Dan Nicolaescu
2009-12-01 20:27 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Dan Nicolaescu @ 2009-12-01 19:54 UTC (permalink / raw)
To: emacs-devel
Currently vc-dir does not work correctly for git trees if not run at the
top of the git tree. This has been reported as a bug a few times.
Eric Hanchrow posted a patch in Bug#1589 that fixes this by using a
git option available in git after version 1.5.5 (which
was released in April 2008)
Should we check in this fix?
What do git users think?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: vc-git bug in vc-dir
2009-12-01 19:54 vc-git bug in vc-dir Dan Nicolaescu
@ 2009-12-01 20:27 ` Tom Tromey
2009-12-01 20:53 ` Dan Nicolaescu
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2009-12-01 20:27 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: emacs-devel
>>>>> "Dan" == Dan Nicolaescu <dann@ics.uci.edu> writes:
Dan> Eric Hanchrow posted a patch in Bug#1589 that fixes this by using a
Dan> git option available in git after version 1.5.5 (which
Dan> was released in April 2008)
Dan> Should we check in this fix?
Dan> What do git users think?
It seems to me that if it fails nicely with older versions of git --
saying what the problem is and how to work around it -- then the patch
should definitely go in.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: vc-git bug in vc-dir
2009-12-01 20:27 ` Tom Tromey
@ 2009-12-01 20:53 ` Dan Nicolaescu
0 siblings, 0 replies; 3+ messages in thread
From: Dan Nicolaescu @ 2009-12-01 20:53 UTC (permalink / raw)
To: Tom Tromey; +Cc: emacs-devel
Tom Tromey <tromey@redhat.com> writes:
> >>>>> "Dan" == Dan Nicolaescu <dann@ics.uci.edu> writes:
>
> Dan> Eric Hanchrow posted a patch in Bug#1589 that fixes this by using a
> Dan> git option available in git after version 1.5.5 (which
> Dan> was released in April 2008)
>
> Dan> Should we check in this fix?
>
> Dan> What do git users think?
>
> It seems to me that if it fails nicely with older versions of git --
> saying what the problem is and how to work around it -- then the patch
> should definitely go in.
It does not fail nicely.
So there's a trade off: vc-dir fails with old versions (we can document
that in NEWS), or it fails all the time (as it currently does).
IMHO dealing nicely with old version is not worth the effort and added
code gunk (plus volunteers to do it are hard to find).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-01 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-01 19:54 vc-git bug in vc-dir Dan Nicolaescu
2009-12-01 20:27 ` Tom Tromey
2009-12-01 20:53 ` Dan Nicolaescu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).