From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: ido.el patch: don't automatically overwrite file on TAB Date: 11 Apr 2004 00:21:44 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1081628755 9020 80.91.224.253 (10 Apr 2004 20:25:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 10 Apr 2004 20:25:55 +0000 (UTC) Cc: Emacs Developement List Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat Apr 10 22:25:47 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BCP2x-00014V-00 for ; Sat, 10 Apr 2004 22:25:47 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BCP2w-0002Lu-01 for ; Sat, 10 Apr 2004 22:25:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCOzz-0000GY-5I for emacs-devel@quimby.gnus.org; Sat, 10 Apr 2004 16:22:43 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BCOzs-0000ES-TR for emacs-devel@gnu.org; Sat, 10 Apr 2004 16:22:36 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BCOzK-00006R-W8 for emacs-devel@gnu.org; Sat, 10 Apr 2004 16:22:34 -0400 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCOzK-00006F-HY for emacs-devel@gnu.org; Sat, 10 Apr 2004 16:22:02 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepb.post.tele.dk (Postfix) with SMTP id A89025EE01D; Sat, 10 Apr 2004 22:22:01 +0200 (CEST) Original-To: Karl Chen In-Reply-To: Original-Lines: 29 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:21453 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:21453 Karl Chen writes: > I find annoying the following behavior: when using ido-write-file, > pressing TAB on a substring that uniquely matches an existing file > will complete the filename and overwrite it without confirmation. > > (Usually when I do [ido-]write-file I mean to make a copy as a new > file. Overwriting existing files based on a substring or > fuzzy+regexp matching is dangerous.) > > The patch below will change the default behavior so that if you > mean to overwrite an existing file you need to press TAB RET. > > > If this change to the default behavior of ido-write-file is not > acceptable please still accept the rest of the patch (ido-complete > and ido-exit-on-unique-tab-completion), because otherwise it is > very difficult to modify the behavior even through advice. I will add your changes to ido. Thanks you. PS: You have not signed papers for contributing to emacs, but this change (and a previous change that I used) is still small enough to not require papers. However, further changes from you will require that you sign papers. -- Kim F. Storm http://www.cua.dk