From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Using strcasecmp in xterm.c Date: Thu, 07 Dec 2006 14:06:56 +0100 Message-ID: References: NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1165497138 12089 80.91.229.10 (7 Dec 2006 13:12:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 7 Dec 2006 13:12:18 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 07 14:12:15 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GsJ2o-0003Rt-7Z for ged-emacs-devel@m.gmane.org; Thu, 07 Dec 2006 14:12:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GsJ2n-0008El-KY for ged-emacs-devel@m.gmane.org; Thu, 07 Dec 2006 08:12:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GsIyM-0003Rt-AM for emacs-devel@gnu.org; Thu, 07 Dec 2006 08:07:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GsIyK-0003Q4-V8 for emacs-devel@gnu.org; Thu, 07 Dec 2006 08:07:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GsIyK-0003Pk-N6 for emacs-devel@gnu.org; Thu, 07 Dec 2006 08:07:32 -0500 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GsIyK-00027q-BR for emacs-devel@gnu.org; Thu, 07 Dec 2006 08:07:32 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepa.post.tele.dk (Postfix) with SMTP id 50D84FAC079; Thu, 7 Dec 2006 14:07:05 +0100 (CET) Original-To: Kenichi Handa In-Reply-To: (Kenichi Handa's message of "Thu\, 07 Dec 2006 20\:16\:41 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:63412 Archived-At: Kenichi Handa writes: > In article , storm@cua.dk (Kim F. Storm) writes: > >> In xterm.c, we use strcasecmp here: > >> struct font_info * >> x_query_font (f, fontname) >> struct frame *f; >> register char *fontname; >> { >> struct x_display_info *dpyinfo = FRAME_X_DISPLAY_INFO (f); >> int i; > >> for (i = 0; i < dpyinfo->n_fonts; i++) >> if (dpyinfo->font_table[i].name >> && (!strcasecmp (dpyinfo->font_table[i].name, fontname) >> || !strcasecmp (dpyinfo->font_table[i].full_name, fontname))) >> return (dpyinfo->font_table + i); >> return NULL; >> } > > >> Shouldn't this use xstricmp which is specifically defined to compare >> fontnames according to the comment in xfaces.c ? > > What is the difference between xstricmp and strcasecmp? I dunno -- but strcasecmp doesn't exist on all systems (I just learned that), and xstricmp comes with Emacs, so it seems safer to use it. -- Kim F. Storm http://www.cua.dk