From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: patch for optional inhibit of delete-other-windows(IDE feature) Date: Mon, 28 Apr 2008 13:26:41 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1209382263 4390 80.91.229.12 (28 Apr 2008 11:31:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Apr 2008 11:31:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 28 13:31:39 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JqRa4-00016m-3S for ged-emacs-devel@m.gmane.org; Mon, 28 Apr 2008 13:31:36 +0200 Original-Received: from localhost ([127.0.0.1]:38235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqRZN-0001u0-I3 for ged-emacs-devel@m.gmane.org; Mon, 28 Apr 2008 07:30:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JqRZK-0001tj-5F for emacs-devel@gnu.org; Mon, 28 Apr 2008 07:30:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JqRZJ-0001rn-3Z for emacs-devel@gnu.org; Mon, 28 Apr 2008 07:30:49 -0400 Original-Received: from [199.232.76.173] (port=40339 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqRZI-0001rY-Bg for emacs-devel@gnu.org; Mon, 28 Apr 2008 07:30:48 -0400 Original-Received: from iwfs.imcode.com ([82.115.149.64] helo=gate.verona.se) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JqRZH-00010i-4C for emacs-devel@gnu.org; Mon, 28 Apr 2008 07:30:48 -0400 Original-Received: from chopper (IDENT:1005@localhost [127.0.0.1]) by gate.verona.se (8.13.4/8.11.4) with ESMTP id m3SBUeQf027812; Mon, 28 Apr 2008 13:30:41 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 27 Apr 2008 21:20:21 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96053 Archived-At: Stefan Monnier writes: >> How do you feel about the current interface: >> delete-other-windows t, inhibits delete-other-windows > > Honestly? I think it's terrible (it's just one-step better than using > advice). But it's the best we have so far. This was pretty funny to me :) Obviously you should be honest. > What I hope to get from the above is an understand of which functions > need to get changed together, then we can create a couple special > window-parameter (call it "foo" and "bar"-windows) and have those > handled accordingly in delete-other-windows, etc... > The crucial difference is that "foo" and "bar" shouldn't have anything > directly to do with delete-other-windows but should instead express > a particular intention behind the use of the window. I.e. an attribute > similar to `dedicated'. Currently I'm working towards this interface: window-parameter set-window-parameter These are like their frame counterparts. The properties are like: "pin" - if t, the window isnt deleted by delete-other-windows "group" - these windows are in a group together and other-window cycles between windows which has the same "group" value. I plan to implement this in next_window(). I'm sure theres even better interfaces, so please be honest :) Maybe "pin" and "group" should really be one parameter or whatever. > >>> So I suggest you work on a separate branch for that. >> I have set up a local bzr branch to work in, that should be enough right? > > Yes, that's fine. If you want to make it public, it's even better. > Note also that I don't see any copyright assignment from you, so you may > want to address this if you want to have your code installed (or if you > want to place a mirror of your branch in Emacs's bzr repository). Ok, how do I go about getting an assignment? > > Stefan -- Joakim Verona