From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Cc: Ted Zlatanov <tzz@lifelogs.com>
Subject: Re: Nebulous streaming/point bug
Date: Thu, 13 Oct 2011 03:04:53 +0200 [thread overview]
Message-ID: <m362jtvgzu.fsf@stories.gnus.org> (raw)
In-Reply-To: <m3k489vief.fsf@stories.gnus.org> (Lars Magne Ingebrigtsen's message of "Thu, 13 Oct 2011 02:34:32 +0200")
Yup. Looks like the problem was where I thought it would be.
Now, I obviously don't recommend the horror included below as a patch,
but it seems to make it possible to read news with Gnus again under
Emacs 24. But it should be fixed in a different way. :-)
I'm not familiar enough with GnuTLS internals to say what the fix really
should be, but I can test patches.
=== modified file 'src/process.c'
--- src/process.c 2011-09-09 01:06:52 +0000
+++ src/process.c 2011-10-13 01:01:35 +0000
@@ -4612,6 +4612,23 @@
some data in the TCP buffers so that select works, but
with custom pull/push functions we need to check if some
data is available in the buffers manually. */
+ if (nfds == 0)
+ {
+ for (channel = 0; channel < MAXDESC; ++channel)
+ {
+ if (! NILP (chan_process[channel]))
+ {
+ struct Lisp_Process *proc = XPROCESS (chan_process[channel]);
+ if (proc && proc->gnutls_p &&
+ proc->infd &&
+ emacs_gnutls_record_check_pending (proc->gnutls_state) > 0)
+ {
+ nfds++;
+ FD_SET (proc->infd, &Available);
+ }
+ }
+ }
+ }
if (nfds == 0 &&
wait_proc && wait_proc->gnutls_p /* Check for valid process. */
/* Do we have pending data? */
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
next prev parent reply other threads:[~2011-10-13 1:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 23:00 Nebulous streaming/point bug Lars Magne Ingebrigtsen
2011-10-12 23:08 ` Lars Magne Ingebrigtsen
2011-10-12 23:14 ` Lars Magne Ingebrigtsen
2011-10-12 23:18 ` Lars Magne Ingebrigtsen
2011-10-12 23:44 ` Lars Magne Ingebrigtsen
2011-10-13 0:34 ` Lars Magne Ingebrigtsen
2011-10-13 1:04 ` Lars Magne Ingebrigtsen [this message]
2011-10-13 12:56 ` Ted Zlatanov
2011-10-27 22:12 ` Ted Zlatanov
2011-11-03 20:20 ` Lars Magne Ingebrigtsen
2011-11-22 17:33 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m362jtvgzu.fsf@stories.gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).