From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] bind n and p in eww bookmark and histories Date: Thu, 10 Nov 2016 19:12:28 +0100 Message-ID: References: <87zil816lq.fsf@udel.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1478803135 21544 195.159.176.226 (10 Nov 2016 18:38:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 10 Nov 2016 18:38:55 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 10 19:38:49 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4uFG-00042v-EN for ged-emacs-devel@m.gmane.org; Thu, 10 Nov 2016 19:38:42 +0100 Original-Received: from localhost ([::1]:48528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4uFJ-0004Vl-Dv for ged-emacs-devel@m.gmane.org; Thu, 10 Nov 2016 13:38:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4tq8-0006oU-3P for emacs-devel@gnu.org; Thu, 10 Nov 2016 13:12:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4tq4-0006bw-Uy for emacs-devel@gnu.org; Thu, 10 Nov 2016 13:12:44 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:44067) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4tq4-0006YS-OR for emacs-devel@gnu.org; Thu, 10 Nov 2016 13:12:40 -0500 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1c4tps-00060p-KT; Thu, 10 Nov 2016 19:12:32 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEWAnsb++d1zk75XdJhp irNjg6k5VHUVITBtjrvd2clKgQaxAAACL0lEQVQ4jW3UzY+TQBQA8Cetpr0VzZr0VqfV1JtmhLY3 hcHgbbMD616VdtqezYJHQ1szR5pNNPy3vhkYqN2+hADzm2HeMB8Qm6AYTv3MuQPVU1DdImYqxaDe dERYEErCakPAQqkEH8KckKmmCNSrlHK/VyYRiMhUQKTLVYQIkhCZVRBQn3LfmfvOzlnReMf5uoIJ 5Zz6d/Pd/EAdyg/jQw3MOYSBJJR/2AcRe324M0BMTLEbMgKA7BJgOXRqGNUgDRSzCt6IpbqmDcBX Axu8Vi3016ew1H2MdB+iAUuBNECTtYapzC2s/R/cZymm2y+b0H3zBNPqIBztJgoFsYJnOI5z4AL7 ACDjZGFf0UUDIy5EndXWfomXgV9cpBch5+qXpOA9gmBWfWrSP9pDeNKA99TVA/TO083BrefjDLxb VX4P3vk4iCswluCNoy/2gLxqxwF6Vh9nhWERuAxEAftdw6Bfgk+vuxFO1eSGQDi+eWs/Z5/sv5iL ENvblX0l+AbBpKsgFdtiMaCCf8dP5Q2sMc0VwCz70VEgGxCuw+lDxmny56cEFuB/GpZH+4E611BC QcFNk3kO7LPO6hu2SFORvBuK0qHuRkJkAMdg8fgjjjyO+Jy1oFZJT62hHPddiODjfL+g7+2i7Jdd LMU9F8SqBSvb39sjxCJTRMZw156AVW0U3PIaytMWaqPg0RBpaNooyPE7gT4Z9KpFwjXRy7E+M0dG u6Z1uqwBaKGrzxQd/wCXYDhiJFrqIQAAAABJRU5ErkJggg== In-Reply-To: <87zil816lq.fsf@udel.edu> (Mark Oteiza's message of "Wed, 09 Nov 2016 20:11:45 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209331 Archived-At: Mark Oteiza writes: > I'd like to add these bindings. Not sure if there is a plan for n and p > to do something else in eww's bookmark or history, judging from the > comments nixed below. > > diff --git a/lisp/net/eww.el b/lisp/net/eww.el > index 7672bf0..1732682 100644 > --- a/lisp/net/eww.el > +++ b/lisp/net/eww.el > @@ -1736,6 +1736,8 @@ eww-bookmark-mode-map > (define-key map [(control k)] 'eww-bookmark-kill) > (define-key map [(control y)] 'eww-bookmark-yank) > (define-key map "\r" 'eww-bookmark-browse) > + (define-key map "n" 'next-line) > + (define-key map "p" 'previous-line) > > (easy-menu-define nil map > "Menu for `eww-bookmark-mode-map'." > @@ -1818,8 +1820,8 @@ eww-history-browse > (defvar eww-history-mode-map > (let ((map (make-sparse-keymap))) > (define-key map "\r" 'eww-history-browse) > -;; (define-key map "n" 'next-error-no-select) > -;; (define-key map "p" 'previous-error-no-select) > + (define-key map "n" 'next-line) > + (define-key map "p" 'previous-line) I'm not sure taking keystrokes we may well want to use later for cursor movements makes all that much sense. People are perfectly capable to move the point around without mode-specific bindings, I think. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no